Skip to content

feat: block non-semantic, neutral text classes #8709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
briangregoryholmes wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: block non-semantic, neutral text classes #8709

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fb91f6
feat: block disallowed text classes
briangregoryholmes Jan 27, 2026
7482be8
remove intentional quality issue
briangregoryholmes Jan 27, 2026
d5128f0
revert quality check script
briangregoryholmes Jan 27, 2026
1edc35f
make check less broad
briangregoryholmes Jan 27, 2026
f92a0af
fix
briangregoryholmes Jan 27, 2026
5e1265a
Merge branch 'main' into bgh/block-disallowed-text-classes
briangregoryholmes Jan 27, 2026
2c8df4e
remove text-slate
briangregoryholmes Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@briangregoryholmes
briangregoryholmes committed Jan 27, 2026
commit f92a0af17c2fce2c3ccd8059b21732c34aacc3fb
4 changes: 2 additions & 2 deletions eslint-plugin-rill/no-disallowed-tailwind-text-colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export default {
const sourceCode = context.sourceCode ?? context.getSourceCode();

return {
// Check Svelte HTML attributes (class="...")
// Check Svelte HTML attributes (class="..." and className="...")
SvelteAttribute(node) {
if (node.key?.name === "class") {
if (node.key?.name === "class" || node.key?.name === "className") {
for (const valueNode of node.value) {
if (valueNode.type === "SvelteLiteral") {
reportAllMatches(valueNode.value, context, valueNode);
Expand Down
4 changes: 2 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ export default [
{
ignores: [
"**/.storybook/*",
"**/.svelte-kit/",
"**/.svelte-kit/**",
"**/gen/*",
"**/node_modules",
"**/node_modules/**",
"**/playwright.config.js",
"**/postcss.config.cjs",
"**/svelte.config.js",
Expand Down
Loading