local PR change review

runtime/parser/parse_canvas.go

@@ -262,8 +262,11 @@ func (p *Parser) parseCanvas(node *Node) error {
 	// Collect metrics view refs from components for direct Canvas -> MetricsView links in the DAG
 	// This must be done BEFORE calling insertResource so the refs are included
 	metricsViewRefs := make(map[ResourceName]bool)
-	// Extract from inline components
+	// Pre-compute set of inline component names for O(1) lookup
+	inlineComponentNames := make(map[string]bool, len(inlineComponentDefs))
 	for _, def := range inlineComponentDefs {
+		inlineComponentNames[def.name] = true
+		// Also extract metrics view refs from inline components
 		for _, ref := range def.refs {
 			if ref.Kind == ResourceKindMetricsView {
 				metricsViewRefs[ref] = true
@@ -274,15 +277,8 @@ func (p *Parser) parseCanvas(node *Node) error {
 	for _, row := range tmp.Rows {
 		for _, item := range row.Items {
 			if item.Component != "" {
-				// Check if this is an external component (not inline)
-				isInline := false
-				for _, def := range inlineComponentDefs {
-					if def.name == item.Component {
-						isInline = true
-						break
-					}
-				}
-				if !isInline {
+				// Check if this is an external component (not inline) - O(1) lookup
+				if !inlineComponentNames[item.Component] {
 					// Look up the external component
 					componentName := ResourceName{Kind: ResourceKindComponent, Name: item.Component}
 					if component, ok := p.Resources[componentName.Normalized()]; ok {

web-common/src/components/tooltip/ConditionalTooltip.svelte

@@ -0,0 +1,52 @@
+<!--
+  @component
+  ConditionalTooltip - A wrapper that optionally applies a Tooltip.
+
+  Use this when you need to conditionally show a tooltip on content without
+  duplicating the inner markup. When `showTooltip` is false, the content
+  renders directly without any wrapper.
+
+  @example
+  <ConditionalTooltip showTooltip={hasError} location="top">
+    <div>Content that may or may not have a tooltip</div>
+    <TooltipContent slot="tooltip-content">
+      Tooltip message here
+    </TooltipContent>
+  </ConditionalTooltip>
+-->
+<script lang="ts">
+  import Tooltip from "./Tooltip.svelte";
+  import type {
+    Alignment,
+    Location,
+  } from "@rilldata/web-common/lib/place-element";
+
+  /** Whether to show the tooltip. When false, content renders without a wrapper. */
+  export let showTooltip: boolean;
+
+  // Tooltip props (pass-through)
+  export let location: Location = "bottom";
+  export let alignment: Alignment = "middle";
+  export let distance = 0;
+  export let pad = 8;
+  export let suppress = false;
+  export let activeDelay = 200;
+  export let hideDelay = 0;
+</script>
+
+{#if showTooltip}
+  <Tooltip
+    {location}
+    {alignment}
+    {distance}
+    {pad}
+    {suppress}
+    {activeDelay}
+    {hideDelay}
+  >
+    <slot />
+    <slot name="tooltip-content" slot="tooltip-content" />
+  </Tooltip>
+{:else}
+  <slot />
+{/if}

web-common/src/features/connectors/connector-type-detector.ts

@@ -0,0 +1,171 @@
+/**
+ * Connector type detection utilities.
+ *
+ * Provides centralized logic for detecting cloud storage connector types
+ * from file paths, URLs, and SQL content. Used by the resource graph and
+ * inspector components.
+ */
+
+/**
+ * Known cloud storage connector types that can be detected from paths/URLs.
+ */
+export type CloudConnectorType =
+  | "s3"
+  | "gcs"
+  | "azure"
+  | "https"
+  | "local_file";
+
+/**
+ * Cloud storage URL prefixes mapped to their connector types.
+ * Uses startsWith for prefix matching.
+ */
+const PATH_PREFIX_MAP: Record<string, CloudConnectorType> = {
+  "s3://": "s3",
+  "s3a://": "s3",
+  "gs://": "gcs",
+  "gcs://": "gcs",
+  "azure://": "azure",
+  "az://": "azure",
+  "abfs://": "azure",
+  "abfss://": "azure",
+  "https://": "https",
+  "http://": "https",
+};
+
+/**
+ * Common data file extensions for HTTP URL detection.
+ * Used to differentiate data URLs from documentation links.
+ */
+const DATA_FILE_EXTENSIONS = [
+  ".parquet",
+  ".csv",
+  ".json",
+  ".ndjson",
+  ".jsonl",
+  ".xlsx",
+  ".xls",
+  ".tsv",
+];
+
+/**
+ * DuckDB read functions that indicate local file access.
+ */
+const DUCKDB_READ_FUNCTIONS = [
+  "read_parquet(",
+  "read_csv(",
+  "read_json(",
+  "read_ndjson(",
+];
+
+/**
+ * Detect connector type from a path/URL prefix.
+ *
+ * Checks if the path starts with a known cloud storage prefix.
+ * Use this for direct paths like "s3://bucket/file.parquet".
+ *
+ * @param path - The path or URL to check
+ * @returns The detected connector type, or undefined if no match
+ *
+ * @example
+ * detectConnectorFromPath("s3://bucket/file.parquet") // "s3"
+ * detectConnectorFromPath("gs://bucket/file.csv") // "gcs"
+ * detectConnectorFromPath("azure://container/file.json") // "azure"
+ * detectConnectorFromPath("https://example.com/data.csv") // "https"
+ * detectConnectorFromPath("/local/file.csv") // undefined
+ */
+export function detectConnectorFromPath(
+  path: string | null | undefined,
+): CloudConnectorType | undefined {
+  if (!path) return undefined;
+
+  const lowerPath = path.toLowerCase();
+
+  for (const [prefix, connectorType] of Object.entries(PATH_PREFIX_MAP)) {
+    if (lowerPath.startsWith(prefix)) {
+      return connectorType;
+    }
+  }
+
+  return undefined;
+}
+
+/**
+ * Detect connector type from content that may contain embedded URLs.
+ *
+ * Searches the content for cloud storage URL patterns anywhere in the string.
+ * Use this for SQL queries or other content that may embed URLs.
+ *
+ * For HTTP URLs, only matches if the URL contains a data file extension
+ * to avoid false positives from documentation links.
+ *
+ * Also detects DuckDB read functions that indicate local file access.
+ *
+ * @param content - The content to search (e.g., SQL query)
+ * @returns The detected connector type, or undefined if no match
+ *
+ * @example
+ * detectConnectorFromContent("SELECT * FROM read_parquet('s3://bucket/file.parquet')") // "s3"
+ * detectConnectorFromContent("SELECT * FROM read_json('https://api.example.com/data.json')") // "https"
+ * detectConnectorFromContent("SELECT * FROM read_csv('/local/file.csv')") // "local_file"
+ * detectConnectorFromContent("SELECT * FROM other_model") // undefined
+ */
+export function detectConnectorFromContent(
+  content: string | null | undefined,
+): CloudConnectorType | undefined {
+  if (!content) return undefined;
+
+  const normalized = content.toLowerCase();
+
+  // Check for cloud storage URL patterns (using includes for embedded URLs)
+  if (normalized.includes("s3://") || normalized.includes("s3a://")) {
+    return "s3";
+  }
+  if (normalized.includes("gs://") || normalized.includes("gcs://")) {
+    return "gcs";
+  }
+  if (
+    normalized.includes("azure://") ||
+    normalized.includes("az://") ||
+    normalized.includes("abfs://") ||
+    normalized.includes("abfss://")
+  ) {
+    return "azure";
+  }
+
+  // For HTTP(S), only match if it looks like a data file URL
+  const httpMatch = normalized.match(/https?:\/\/[^\s'"]+/g);
+  if (httpMatch) {
+    for (const url of httpMatch) {
+      if (DATA_FILE_EXTENSIONS.some((ext) => url.includes(ext))) {
+        return "https";
+      }
+    }
+  }
+
+  // Check for DuckDB read functions (indicates local file access)
+  for (const func of DUCKDB_READ_FUNCTIONS) {
+    if (normalized.includes(func)) {
+      return "local_file";
+    }
+  }
+
+  return undefined;
+}
+
+/**
+ * Detect connector type by checking multiple sources in priority order.
+ *
+ * Convenience function that tries path detection first, then content detection.
+ * Useful when you have both a direct path and SQL content to check.
+ *
+ * @param path - A direct path/URL to check first
+ * @param content - Content to search if path doesn't match
+ * @returns The detected connector type, or undefined if no match
+ */
+export function detectConnector(
+  path: string | null | undefined,
+  content: string | null | undefined,
+): CloudConnectorType | undefined {
+  return detectConnectorFromPath(path) ?? detectConnectorFromContent(content);
+}

web-common/src/features/resource-graph/embedding/ResourceGraph.svelte

@@ -25,6 +25,7 @@
   import { onDestroy } from "svelte";
   import { UI_CONFIG, FIT_VIEW_CONFIG } from "../shared/config";
   import { isGraphExpanded } from "../inspector/graph-inspector-store";
+  import type { ResourceStatusFilter } from "../shared/types";
 
   export let resources: V1Resource[] | undefined;
   export let isLoading = false;
@@ -37,7 +38,7 @@
   export let showControls = true;
   export let enableExpansion = true;
   export let searchQuery = "";
-  export let statusFilter: "all" | "pending" | "errored" = "all";
+  export let statusFilter: ResourceStatusFilter = "all";
 
   // New props for modularity
   export let onExpandedChange: ((id: string | null) => void) | null = null;

web-common/src/features/resource-graph/graph-canvas/ResourceNode.svelte

@@ -8,7 +8,7 @@
   import { ResourceKind } from "@rilldata/web-common/features/entity-management/resource-selectors";
   import type { ResourceNodeData } from "../shared/types";
   import { V1ReconcileStatus } from "@rilldata/web-common/runtime-client";
-  import Tooltip from "@rilldata/web-common/components/tooltip/Tooltip.svelte";
+  import ConditionalTooltip from "@rilldata/web-common/components/tooltip/ConditionalTooltip.svelte";
   import TooltipContent from "@rilldata/web-common/components/tooltip/TooltipContent.svelte";
 
   export let id: string;
@@ -75,66 +75,14 @@
   $: routeHighlighted = (data as any)?.routeHighlighted === true;
 </script>
 
-{#if hasError}
-  <Tooltip location="top" distance={8} activeDelay={150}>
-    <!-- svelte-ignore a11y-click-events-have-key-events -->
-    <!-- svelte-ignore a11y-no-static-element-interactions -->
-    <div
-      class="node"
-      class:selected
-      class:route-highlighted={routeHighlighted}
-      class:error={hasError}
-      class:root={data?.isRoot}
-      style:--node-accent={color}
-      style:width={width ? `${width}px` : undefined}
-      style:height={height ? `${height}px` : undefined}
-      data-kind={kind}
-      role="button"
-      tabindex="0"
-    >
-      <Handle
-        id="target"
-        type="target"
-        position={Position.Top}
-        isConnectable={isConnectable ?? true}
-      />
-      <Handle
-        id="source"
-        type="source"
-        position={Position.Bottom}
-        isConnectable={isConnectable ?? true}
-      />
-
-      <div class="icon-wrapper" style={`background:${color}20`}>
-        <svelte:component this={icon} size="16px" {color} />
-      </div>
-      <div class="details">
-        <p class="title" title={data?.label}>{data?.label}</p>
-        <p class="meta">
-          {#if kind}
-            {displayResourceKind(kind)}
-          {:else}
-            Unknown
-          {/if}
-        </p>
-        <p class="status error">{effectiveStatusLabel}</p>
-      </div>
-    </div>
-    <TooltipContent slot="tooltip-content" maxWidth="420px" variant="light">
-      <div class="error-tooltip-content">
-        <span class="error-tooltip-title">Error</span>
-        <pre class="error-tooltip-message">{data?.resource?.meta
-            ?.reconcileError}</pre>
-      </div>
-    </TooltipContent>
-  </Tooltip>
-{:else}
+<ConditionalTooltip showTooltip={hasError} location="top" distance={8} activeDelay={150}>
   <!-- svelte-ignore a11y-click-events-have-key-events -->
   <!-- svelte-ignore a11y-no-static-element-interactions -->
   <div
     class="node"
     class:selected
     class:route-highlighted={routeHighlighted}
+    class:error={hasError}
     class:root={data?.isRoot}
     style:--node-accent={color}
     style:width={width ? `${width}px` : undefined}
@@ -169,11 +117,18 @@
         {/if}
       </p>
       {#if effectiveStatusLabel}
-        <p class="status">{effectiveStatusLabel}</p>
+        <p class="status" class:error={hasError}>{effectiveStatusLabel}</p>
       {/if}
     </div>
   </div>
-{/if}
+  <TooltipContent slot="tooltip-content" maxWidth="420px" variant="light">
+    <div class="error-tooltip-content">
+      <span class="error-tooltip-title">Error</span>
+      <pre class="error-tooltip-message">{data?.resource?.meta
+          ?.reconcileError}</pre>
+    </div>
+  </TooltipContent>
+</ConditionalTooltip>
 
 <style lang="postcss">
   .node {