Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove extra loop
  • Loading branch information
k-anshul committed Apr 24, 2026
commit cb1146aa0508bf4f15eb5a7117f8c9af689dca26
10 changes: 5 additions & 5 deletions runtime/server/instances.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,9 @@
Modified: summary.VarsModified,
}, nil
}
// Ideally pullEnv should be called inside ReloadConfig only since it is just a simple version of ReloadConfig on local
// The issue is that `adminOverride` is available in server and not in runtime
// TODO: revisit this when relooking adminOverride

Check failure on line 314 in runtime/server/instances.go

View workflow job for this annotation

GitHub Actions / lint

File is not properly formatted (gci)
count, modified, err := s.pullEnv(ctx, req.InstanceId)
Comment thread
k-anshul marked this conversation as resolved.
Outdated
if err != nil {
return nil, err
Expand Down Expand Up @@ -362,18 +365,15 @@

// Check if all environments are already up to date
equal := true
totalCount := 0
for env, cloudVars := range cloudPerEnv {
totalCount += len(cloudVars)
if !maps.Equal(cloudVars, localPerEnv[env]) {
equal = false
break
}
}

totalCount := 0
for _, vars := range cloudPerEnv {
totalCount += len(vars)
}

if equal {
return totalCount, false, nil
}
Expand Down
Loading