Skip to content

Fix trivial warnings #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjmurillo merged 4 commits into from
Jun 14, 2024
Merged

Fix trivial warnings #88

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fc45fa
Move suppression of SA1633 to .editorconfig
MattKotsenas Jun 14, 2024
b2db83f
Clean up XMLDocs warnings
MattKotsenas Jun 14, 2024
64dfc85
Clean up dead TODOs
MattKotsenas Jun 14, 2024
aa30448
Move SA1101 to .editorconfig
MattKotsenas Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up dead TODOs
  • Loading branch information
@MattKotsenas
MattKotsenas committed Jun 14, 2024
commit 64dfc8588cf61ae8b3250088e6e041288548f2ac
2 changes: 0 additions & 2 deletions Source/Moq.Analyzers.Test/AsAcceptOnlyInterfaceAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@ public static IEnumerable<object[]> TestData()
{
return new object[][]
{
// TODO: .As<BaseSampleClass> and .As<SampleClass> feels redundant
["""new Mock<BaseSampleClass>().As<{|Moq1300:BaseSampleClass|}>();"""],
["""new Mock<BaseSampleClass>().As<{|Moq1300:SampleClass|}>();"""],
["""new Mock<SampleClass>().As<ISampleInterface>();"""],
// TODO: Testing with .Setup() and .Returns() seems unnecessary.
["""new Mock<SampleClass>().As<ISampleInterface>().Setup(x => x.Calculate(It.IsAny<int>(), It.IsAny<int>())).Returns(10);"""],
}.WithNamespaces().WithReferenceAssemblyGroups();
}
Expand Down