Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,14 @@ export function asNumber(value) {
}
const n = Number(value);
const valid = typeof n === "number" && !Number.isNaN(n);

if (/\.\d*0$/.test(value)) {
// It's a number, that's cool - but we need it as a string so it doesn't screw
// with the user when entering dollar amounts or other values (such as those with
// specific precision or number of significant digits)
return value;
}

return valid ? n : value;
}

Expand Down
30 changes: 30 additions & 0 deletions test/NumberField_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,36 @@ describe("NumberField", () => {
expect(node.querySelector("input[type=text]").id)
.eql("root");
});

it("should render with trailing zeroes", () => {
const {node} = createFormComponent({schema: {
type: "number"
}});

Simulate.change(node.querySelector("input"), {
target: {value: "2."}
});
expect(node.querySelector(".field input").value)
.eql("2.");

Simulate.change(node.querySelector("input"), {
target: {value: "2.0"}
});
expect(node.querySelector(".field input").value)
.eql("2.0");

Simulate.change(node.querySelector("input"), {
target: {value: "2.00"}
});
expect(node.querySelector(".field input").value)
.eql("2.00");

Simulate.change(node.querySelector("input"), {
target: {value: "2.000"}
});
expect(node.querySelector(".field input").value)
.eql("2.000");
});
});

describe("SelectWidget", () => {
Expand Down