Upgrade e32 4.3.0

[rjwats]

No description provided.

[rjwats]

Is anyone able to give this a test/review for me?

[proddy]

<RouterTabs> is missing the children property?

[rjwats]

Humm.. shouldn't be, are you getting an error?

[rjwats]

try an "npm ci" - could be a deps issue?

[proddy]

try an "npm ci" - could be a deps issue?

no, your repo works just fine. The problem is on my side with my project. If apply the same changes for react18 to my fork I get:

[rjwats]

Oh right, this is a change in React 18:

FC used to be:

and now is:

So children must be declared, there's a helper you can use to mix these into existing interfaces, or you can do this like i'm doing in my PR with a utility type your props interfaces can extend from :)

[proddy]

BTW I also modifed /src/index.tsx to

import { StrictMode } from 'react';
import { createRoot } from 'react-dom/client';
import { BrowserRouter } from 'react-router-dom';

import App from './App';

const root = createRoot(document.getElementById('root') as HTMLElement);

root.render(
  <StrictMode>
    <BrowserRouter>
      <App />
    </BrowserRouter>
  </StrictMode>
);

as per https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis

[rjwats]

ah, yes, thanks :)

…

On Tue, 24 May 2022, 22:03 Proddy, ***@***.***> wrote: BTW I also modifed /src/index.tsx to import { StrictMode } from 'react';import { createRoot } from 'react-dom/client';import { BrowserRouter } from 'react-router-dom'; import App from './App'; const root = createRoot(document.getElementById('root') as HTMLElement); root.render( <StrictMode> <BrowserRouter> <App /> </BrowserRouter> </StrictMode>); as per https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis — Reply to this email directly, view it on GitHub <#301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKE4VDNLUZS54KQ65DRFE3VLU7ZBANCNFSM5WRTYQSA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>