Fix channel scoping in chain.SkipIfStillRunning#263
Closed
brunotm wants to merge 1 commit intorobfig:masterfrom
Closed
Fix channel scoping in chain.SkipIfStillRunning#263brunotm wants to merge 1 commit intorobfig:masterfrom
brunotm wants to merge 1 commit intorobfig:masterfrom
Conversation
robfig
pushed a commit
that referenced
this pull request
Jan 4, 2020
It was an error in channel scoping that was identified in pull #263. This adds a unit test to identify that issue and verify the fix.
Owner
|
Thank you for finding and fixing this, what a bad bug! I wrote a unit test to verify the fix, pushed it as ccba498, and tagged v3.0.1. |
haiheipijuan
pushed a commit
to haiheipijuan/cron
that referenced
this pull request
Jun 15, 2021
It was an error in channel scoping that was identified in pull robfig#263. This adds a unit test to identify that issue and verify the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the scoping of the channel used for skipping jobs in SkipIfStillRunning middleware, which led to incorrectly skipping all-1 tasks added at the same time.