Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-tauri/src/panel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ pub fn position_panel_at_tray_icon(

let icon_center_x_phys = icon_phys_x + (icon_width_phys / 2);
let panel_x_phys = icon_center_x_phys - (window_width_phys / 2);
let padding_phys = (8.0 * scale_factor).round() as i32;
let padding_phys = (-8.0 * scale_factor).round() as i32;
let panel_y_phys = icon_phys_y + icon_height_phys + padding_phys;

let final_pos = tauri::PhysicalPosition::new(panel_x_phys, panel_y_phys);
Expand Down
43 changes: 23 additions & 20 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
const PANEL_WIDTH = 350;
const MAX_HEIGHT_FALLBACK_PX = 600;
const MAX_HEIGHT_FRACTION_OF_MONITOR = 0.8;
const ARROW_OVERHEAD_PX = 13; // .tray-arrow (7px) + wrapper pt-1.5 (6px)

type PluginState = {
data: PluginOutput | null
Expand Down Expand Up @@ -489,27 +490,29 @@ function App() {
}

return (
<div
ref={containerRef}
className="bg-card rounded-lg border shadow-lg overflow-hidden select-none"
style={maxPanelHeightPx ? { maxHeight: `${maxPanelHeightPx}px` } : undefined}
>
<div className="flex h-full min-h-0 flex-row">
<SideNav
activeView={activeView}
onViewChange={setActiveView}
plugins={navPlugins}
/>
<div className="flex-1 flex flex-col px-3 pt-2 pb-1.5 min-w-0">
<div className="flex-1 min-h-0 overflow-y-auto">
{renderContent()}
</div>
<PanelFooter
version={appVersion}
autoUpdateNextAt={autoUpdateNextAt}
updateStatus={updateStatus}
onUpdateInstall={triggerInstall}
<div ref={containerRef} className="flex flex-col items-center pt-1.5">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low

src/App.tsx:492

The new wrapper's pt-1.5 padding and .tray-arrow height aren't accounted for in maxPanelHeightPx. Consider subtracting the wrapper overhead from the inner card's maxHeight so the footer remains visible when content is tall.

🚀 Want me to fix this? Reply ex: "fix it for me".

<div className="tray-arrow" />
<div
className="bg-card rounded-lg border shadow-lg overflow-hidden select-none w-full"
style={maxPanelHeightPx ? { maxHeight: `${maxPanelHeightPx - ARROW_OVERHEAD_PX}px` } : undefined}
>
<div className="flex h-full min-h-0 flex-row">
<SideNav
activeView={activeView}
onViewChange={setActiveView}
plugins={navPlugins}
/>
<div className="flex-1 flex flex-col px-3 pt-2 pb-1.5 min-w-0">
<div className="flex-1 min-h-0 overflow-y-auto">
{renderContent()}
</div>
<PanelFooter
version={appVersion}
autoUpdateNextAt={autoUpdateNextAt}
updateStatus={updateStatus}
onUpdateInstall={triggerInstall}
/>
</div>
</div>
</div>
</div>
Expand Down
22 changes: 22 additions & 0 deletions src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,28 @@ body,
padding: 0;
}

/* Arrow pointing up toward the tray icon */
.tray-arrow {
width: 0;
height: 0;
border-left: 7px solid transparent;
border-right: 7px solid transparent;
border-bottom: 7px solid var(--border);
position: relative;
flex-shrink: 0;
}
.tray-arrow::after {
content: "";
position: absolute;
left: -6px;
top: 1.5px;
width: 0;
height: 0;
border-left: 6px solid transparent;
border-right: 6px solid transparent;
border-bottom: 6px solid var(--card);
}

/* Remove focus rings - this is a menu bar app, not keyboard-navigated */
*:focus,
*:focus-visible {
Expand Down