plugins: Add line scope API for overview/detail filtering#44
Conversation
- Added a `scope` property to plugin lines to differentiate between "overview" and "detail" views. - Updated various plugin configurations to include the new `scope` property for better line categorization. - Implemented filtering logic in the `ProviderCard` and `OverviewPage` components to display lines based on the selected scope. - Enhanced tests to validate the new filtering behavior and ensure correct rendering of lines based on scope.
- Deleted the Claude and Codex plugin files, including their icons, JavaScript logic, and configuration files, as they are no longer in use. - Cleaned up associated test files for both plugins to maintain a tidy codebase.
- Added entry for bundled_plugins directory to .gitignore to prevent build artifacts from being tracked in the repository.
Add line scope API and filter provider lines by scope in
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f59faea77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[serde(rename = "type")] | ||
| pub line_type: String, | ||
| pub label: String, | ||
| pub scope: String, |
There was a problem hiding this comment.
Existing installations already have app_data/plugins/*/plugin.json without a scope field, and load_plugins_from_dir silently skips plugins that fail serde_json::from_str. With scope now required, those legacy plugins will fail to deserialize, leaving users with an empty plugin list after upgrade (install_dir isn’t emptied, so bundled plugins are not copied over). This is a regression for any user upgrading from a version that wrote manifests without scope.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 31 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/specs/2026-02-02-line-scope.md">
<violation number="1" location="docs/specs/2026-02-02-line-scope.md:34">
P2: Documentation inconsistency: This line claims bundled plugins were "updated" but according to the PR description, `bundled_plugins/` was removed from the repo and added to `.gitignore`. This spec entry should either be removed or updated to reflect that these files are now gitignored and generated during CI rather than being tracked/updated.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Updated .gitignore to keep the bundled_plugins directory while ignoring its contents, ensuring CI-generated files are not tracked. - Removed outdated reference to bundled plugins in the line scope documentation, reflecting the latest plugin structure.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| { "type": "progress", "label": "Session", "scope": "overview" }, | ||
| { "type": "progress", "label": "Weekly", "scope": "overview" }, | ||
| { "type": "progress", "label": "Sonnet", "scope": "detail" }, | ||
| { "type": "progress", "label": "Extra usage", "scope": "detail" } |
There was a problem hiding this comment.
Manifest missing line declarations causes hidden data
Medium Severity
The Claude plugin can output an "Opus" line (line 231 in plugin.js) and the Cursor plugin can output a "Bonus spend" line (line 225 in plugin.js), but neither is declared in their respective plugin.json manifests. With the new scope filtering, the overview page only shows lines whose labels match manifest entries with scope: "overview". These undeclared lines will be hidden from the overview page even when they contain valid usage data. This creates an inconsistent experience where data appears on the detail page but not on overview.
Additional Locations (1)
1 participant
Add
scopefield to plugin manifest lines to control visibility on Overview vs Detail pages.Summary
scope: "overview" | "detail"field to manifest linesscope: "overview"; detail pages show allChanges
Made with Cursor
Note
Medium Risk
Introduces a required
lines[].scopefield in plugin manifests and changes UI rendering based on it; missing/incorrect scopes could break plugin loading or hide metrics unexpectedly.Overview
Adds a required
scope: "overview" | "detail"to every manifest line, propagating it through both the Rust manifest loader/DTOs and the TypeScriptManifestLinetype.Updates the UI to filter provider card skeleton + runtime lines on the Overview page (only
overviewscope), while provider detail pages show all lines; tests and docs/specs are updated accordingly. Also stops tracking bundled plugin build artifacts by gitignoringsrc-tauri/resources/bundled_plugins/*and removing the previously committed bundled plugin files.Written by Cursor Bugbot for commit cd82b15. This will update automatically on new commits. Configure here.
Summary by cubic
Adds a required scope field to plugin manifest lines and updates the UI to show overview lines on the Overview page while detail pages show all lines. Also removes bundled plugin assets from the repo and ignores them as build artifacts.
New Features
Migration
Written for commit cd82b15. Summary will update on new commits.