-
Notifications
You must be signed in to change notification settings - Fork 245
feat: Add pace tracking indicator for usage metrics #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
81d21ac
feat: Add pace tracking indicator for usage metrics
robinebers 90aed4e
feat: Enhance MetricLine with periodDurationMs for pace tracking
robinebers f1f000f
fix: Correct period durations for pace tracking
robinebers 0a86318
fix: Update pace status logic in MetricLineRenderer
robinebers 822debe
fix: Refine pace status logic in MetricLineRenderer
robinebers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| export type PaceStatus = "ahead" | "on-track" | "behind" | ||
|
|
||
| export type PaceResult = { | ||
| status: PaceStatus | ||
| /** Projected usage at end of period (same unit as used/limit) */ | ||
| projectedUsage: number | ||
| } | ||
|
|
||
| /** | ||
| * Calculate pace status based on current usage rate vs. period duration. | ||
| * | ||
| * @param used - Current usage amount | ||
| * @param limit - Maximum/limit amount | ||
| * @param resetsAtMs - Timestamp (ms) when the period resets | ||
| * @param periodDurationMs - Total duration of the period (ms) | ||
| * @param nowMs - Current timestamp (ms) | ||
| * @returns PaceResult or null if calculation not possible | ||
| */ | ||
| export function calculatePaceStatus( | ||
| used: number, | ||
| limit: number, | ||
| resetsAtMs: number, | ||
| periodDurationMs: number, | ||
| nowMs: number | ||
| ): PaceResult | null { | ||
| // Validate inputs | ||
| if ( | ||
| !Number.isFinite(used) || | ||
| !Number.isFinite(limit) || | ||
| !Number.isFinite(resetsAtMs) || | ||
| !Number.isFinite(periodDurationMs) || | ||
| !Number.isFinite(nowMs) | ||
| ) { | ||
| return null | ||
| } | ||
|
|
||
| if (limit <= 0 || periodDurationMs <= 0) { | ||
| return null | ||
| } | ||
|
|
||
| // Calculate period start and elapsed time | ||
| const periodStartMs = resetsAtMs - periodDurationMs | ||
| const elapsedMs = nowMs - periodStartMs | ||
|
|
||
| // Skip if period hasn't started or we're past the reset | ||
| if (elapsedMs <= 0 || nowMs >= resetsAtMs) { | ||
| return null | ||
| } | ||
|
|
||
| // Skip if less than 5% of period has elapsed (too early to predict accurately) | ||
| const elapsedFraction = elapsedMs / periodDurationMs | ||
| if (elapsedFraction < 0.05) { | ||
| return null | ||
| } | ||
|
|
||
| // Calculate projected usage at end of period | ||
| // projectedUsage = (used / elapsedTime) * periodDuration | ||
| const usageRate = used / elapsedMs | ||
| const projectedUsage = usageRate * periodDurationMs | ||
|
|
||
| // Determine status based on projected usage vs limit | ||
| let status: PaceStatus | ||
| if (projectedUsage <= limit * 0.8) { | ||
| status = "ahead" | ||
| } else if (projectedUsage <= limit) { | ||
| status = "on-track" | ||
| } else { | ||
| status = "behind" | ||
| } | ||
|
|
||
| return { status, projectedUsage } | ||
| } | ||
|
|
||
| /** | ||
| * Get the CSS color class for a pace status. | ||
| */ | ||
| export function getPaceStatusColor(status: PaceStatus): string { | ||
| switch (status) { | ||
| case "ahead": | ||
| return "text-green-500" | ||
| case "on-track": | ||
| return "text-yellow-500" | ||
| case "behind": | ||
| return "text-red-500" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Low
plugin_engine/runtime.rs:369Consider adding anis_finite()check before castingntou64, consistent with the validation forusedandlimitabove. Without it,Infinitysaturates tou64::MAXand silently passes the> 0check.