Fix requiresMainQueueSetup warnings #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atticoos
reviewed
Oct 9, 2019
ios/RNFrequency.m
Outdated
|
|
||
| + (BOOL)requiresMainQueueSetup | ||
| { | ||
| return NO; |
Contributor
There was a problem hiding this comment.
Do we know enough about TGSineWaveToneGenerator's initialization process for it to safely initialize on a non-main thread? YES might be a safe fallback
Contributor
Author
There was a problem hiding this comment.
👍 Fixed and rebased the change in:
https://github.com/robinpowered/react-native-frequency/pull/7/files#diff-bf1b5034a87a06f469c02538132dd913R15
christophermark
force-pushed
the
fix-requiresMainQueueSetup-warning
branch
from
5f45d26 to
d44b9d5
Compare
Contributor
Author
|
Updated to preserve functionality - this is now run in the main thread. |
atticoos
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes some of the warnings we were getting about requiring main queue setup in our native modules, by explicitly setting whether our native modules can be loaded in the background.
Prior art:
https://github.com/wix/react-native-navigation/pull/1983/files
facebook/react-native@220034c
invertase/react-native-firebase#491