Skip to content

Fix Unresolvable dependency, Rollbar should not be started when there… #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Fix Unresolvable dependency, Rollbar should not be started when there… #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/RollbarServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,18 @@ public function register(): void
*
* This is where we can start listening for events.
*
* @param RollbarLogger $logger This parameter is injected by the service container, and is required to ensure that
* the Rollbar logger is initialized.
* @return void
*
* @since 8.1.0
*/
public function boot(RollbarLogger $logger): void
public function boot(): void
{
if ($this->stop() === true) {
return;
}

//ensure that the Rollbar logger is initialized
app(RollbarLogger::class);
// Set up telemetry if it is enabled.
if (null !== Rollbar::getTelemeter()) {
$this->setupTelemetry($this->getConfigs($this->app));
Expand Down