Skip to content

Fixed #171 Log context passed directly to telemetry body. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Fixed #171 Log context passed directly to telemetry body. #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/TelemetryListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ protected function logMessageHandler(MessageLogged $message): void
EventType::Log,
// Telemetry does not support all PSR-3 or RFC-5424 levels, so we need to convert them.
Telemeter::getLevelFromPsrLevel($message->level),
array_merge(
$message->context,
['message' => $message->message],
),
[
'message' => $message->message,
'context' => $message->context,
],
);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/TelemetryListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function testTelemetryCapturesLaravelLogs(): void

self::assertSame(EventLevel::Debug, $lastItem->level);
self::assertSame('telemetry test message', $lastItem->body->message);
self::assertSame(['foo' => 'bar'], $lastItem->body->extra);
self::assertSame(['context' => ['foo' => 'bar']], $lastItem->body->extra);
}

public function testTelemetryDoesNotCaptureLaravelLogsWhenDisabled(): void
Expand Down