Skip to content

Conversation

degecko
Copy link

@degecko degecko commented Aug 27, 2018

As per the official documentation, the parameter for the token on the logging config file should be called access_token. However, without this fix, you need to have both access_token and token set to the same value, under logging.channels.rollbar. Otherwise, it will not work.

This adds another hotfix to replace the $key, when its value is "token", with "access_token".

P.S. As an alternative, you could also replace the line: $token = static::config('token'); with $token = static::config('access_token');, just so we don't add another if. I'll leave the authors to decide which is best.


Later edit: I went ahead and created a new commit to remove the extra if and fix the actual bug. But feel free to use either of the versions.

@chrispappas
Copy link

I came here to make a bug report about this exact issue - following the instructions I configured access_token but as this PR fixes, Rollbar just stops because the token is not set. Looking forward to this getting merged soon, please!

@slashsbin
Copy link

Please release this.

@ArturMoczulski ArturMoczulski merged commit e02e4d1 into rollbar:master Sep 26, 2018
@ArturMoczulski
Copy link

@degecko thanks for submitting this PR. I merged it to master.

@ArturMoczulski ArturMoczulski modified the milestones: v4.1.0, v4.0.1 Sep 26, 2018
@ArturMoczulski
Copy link

@degecko released in v4.0.1 right here https://github.com/rollbar/rollbar-php-laravel/releases/tag/v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants