Skip to content

Adding compatibility with Lumen without sessions #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adding compatibility with Lumen without sessions #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/MonologHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ protected function addContext(array $context = [])
}

// Add session data.
if ($session = $this->app->session->all()) {
$session = isset($this->app) ? $this->app->session->all() : null;
Copy link

@tristanjahier tristanjahier Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should'nt you check for $this->app->has('session') here instead of isset($this->app)?

Copy link
Author

@victormln victormln Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you shouldn't because if $this->app is null you cannot call the method has, and that's why it's failing now and it's better to check first with an isset()

Copy link

@tristanjahier tristanjahier Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my use cases it was only failing because session does not exist on $this->app, not because $this->app does not exist at all. In which situation $this->app is not defined?

Copy link

@tristanjahier tristanjahier Oct 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested again and $this->app does exists in Lumen, that is the ->session part that is failing.

Changing the if condition to $this->app->has('session') && $session = $this->app->session->all() solves the problem.

if ($session) {
// Add user session information.
if (isset($person['session'])) {
$person['session'] = array_merge($session, $person['session']);
Expand Down