Added fallback on getKey method. #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxsx
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Hi @GertjanRoke
This is a nice feature. Thanks for the PR 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just implemented this package into my project and my primary key is not
id, so this means theperson_fnkey in the config will not work for me because it looks at theidattribute.So I added a fallback on the function of Laravel:
getKey(), this will look at if the$primaryKeyname is changed inside the modal else will send the value from theidattribute.If you have any question feel free to ask.