Introduce a helper returning the system CPUs #1018
Conversation
core/base/inc/TROOT.h
Outdated
| UInt_t GetImplicitMTPoolSize(); | ||
|
|
||
| /// Get the number of system CPUs. | ||
| UInt_t GetNCPUs(); |
There was a problem hiding this comment.
(Especially since) this is not configurable, this routine belongs in TSystem. Thanks.
|
Starting build on |
|
Hi @xvallspl , what problem is this change solving? |
|
It's a proposal, totally open to discussion. I found myself in need of this piece of code several times and I always thought it would be cool to have it as a single call instead of having to remember those three lines. You can see it a nicer and useful way for writing nCPUs dependent, processor-agnostic code. I would say it's better than replicating the current process of getting the number of CPUs all over the place. This function will be helpful when parallelizing without IMT/tbb, where you may still be in need of knowing the number of threads you can use. |
...refactoring the old way of obtaining it.
|
Starting build on |
|
Moved it to TSystem. |
|
Just remembered std::thread::hardware_concurrency. Closing the PR. |
4 participants
...refactoring the old way of obtaining it.
Just for convenience.