Skip to content

Fix massive parallel execution of TThreadedObject #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xvallspl merged 1 commit into from
Sep 25, 2017
Merged

Fix massive parallel execution of TThreadedObject #1030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/thread/inc/ROOT/TThreadedObject.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "TList.h"
#include "TError.h"

#include <algorithm>
#include <functional>
#include <map>
#include <memory>
Expand Down Expand Up @@ -286,7 +287,7 @@ namespace ROOT {

};

template<class T> unsigned TThreadedObject<T>::fgMaxSlots = 64;
template<class T> unsigned TThreadedObject<T>::fgMaxSlots = std::max(std::thread::hardware_concurrency(), 64u);
Copy link
Member

@amadio amadio Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply use std::thread::hardware_concurrency()?

Copy link
Contributor Author

@xvallspl xvallspl Sep 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For not breaking previous behaviour? But yeah, I was told to keep a minimum of 32.

One step at a time #1019


} // End ROOT namespace

Expand Down