Skip to content

Conversation

@saisoma123
Copy link
Contributor

@saisoma123 saisoma123 commented Jun 9, 2022

This Pull request:

Fixes the cmakeDIr undefined error that occurs on Windows

Changes or fixes:

Added cmakeDir variable to cpt.py

Checklist:

  • tested changes locally: Ran --last-stable nsis with cpt.py, the error does not occur anymore
  • [NA] updated the docs (if necessary)

This PR fixes issue 426 (root-project/cling#426)

@saisoma123 saisoma123 requested a review from Axel-Naumann as a code owner June 9, 2022 20:37
@phsft-bot
Copy link

Can one of the admins verify this patch?

@Axel-Naumann Axel-Naumann requested review from vgvassilev and removed request for Axel-Naumann June 10, 2022 07:27
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 2f3e141 into root-project:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants