Skip to content

Try to completely remove identifiers that are namespace in the GMI #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junaire wants to merge 1 commit into from
Closed

Try to completely remove identifiers that are namespace in the GMI #10969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Try to completely remove identifiers that are namespace in the GMI 
This patch is to verify if we really need to store identifiers that
are namespace in GlobalModuleIndex, which greatly increase the maximum
memory pressure. Send this to trigger ROOT's CI so we can have a full
test, and will be closed if the direction is wrong.
No need for code review or merge.

Signed-off-by: Jun Zhang <[email protected]>
  • Loading branch information
@junaire
junaire committed Jul 15, 2022
commit 1ffc914de3ec3b03e5b841089ccd19cbc460b602
4 changes: 2 additions & 2 deletions core/metacling/src/TCling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,11 +1135,11 @@ static GlobalModuleIndex *loadGlobalModuleIndex(cling::Interpreter &interp)
if (TagDecl *TD = llvm::dyn_cast<TagDecl>(ND)) {
if (TD->isCompleteDefinition())
Register(TD);
} else if (NamespaceDecl *NSD = llvm::dyn_cast<NamespaceDecl>(ND)) {
Register(NSD, /*AddSingleEntry=*/ false);
}
else if (TypedefNameDecl *TND = dyn_cast<TypedefNameDecl>(ND))
Register(TND);
else if (isa<FunctionDecl>(ND) && !isa<CXXMethodDecl>(ND))
Register(ND);
// FIXME: Add the rest...
return true; // continue decending
}
Expand Down