Skip to content

[cling] Reuse existing weak symbols, also from JIT: #12018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Axel-Naumann wants to merge 5 commits into from
Closed

[cling] Reuse existing weak symbols, also from JIT: #12018

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89cf687
[cling] Reuse existing weak symbols, also from JIT:
Axel-Naumann Jan 12, 2023
b6d2061
[cling] JIT: only re-use *large* existing weak functions:
Axel-Naumann Jan 12, 2023
7fae1ac
[cling] JIT: separate re-use of weak sym vars, funcs (NFCI).
Axel-Naumann Jan 12, 2023
ba2f10e
[cling] JIT: find existing weak symbol without materializer:
Axel-Naumann Jan 12, 2023
42e9bdf
[cling] For MSVC weak symbols, re-use even small funcs:
Axel-Naumann Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[cling] For MSVC weak symbols, re-use even small funcs: 
Without, the JIT fails to compile roottest/root/aclic/misc/assertROOT7027.C
correctly.
  • Loading branch information
@Axel-Naumann
Axel-Naumann committed Jan 17, 2023
commit 42e9bdf3b0201a6a8f63e3e0c1dfee31f449808d
4 changes: 3 additions & 1 deletion interpreter/cling/lib/Interpreter/BackendPasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,13 +298,15 @@ namespace {
bool runOnFunc(Function& Func) {
if (Func.isDeclaration())
return false; // no change.

#ifndef _WIN32
// MSVC's stdlib gets symbol issues; i.e. apparently: JIT all or none.
if (Func.getInstructionCount() < 50) {
// This is a small function. Keep its definition to retain it for
// inlining: the cost for JITting it is small, and the likelihood
// that the call will be inlined is high.
return false;
}
#endif
if (shouldRemoveGlobalDefinition(Func)) {
Func.deleteBody(); // make this a declaration
return true; // a change!
Expand Down