Skip to content

[cling] Fix TLS in the cling JIT #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 2 commits into from
Nov 6, 2017
Merged

[cling] Fix TLS in the cling JIT #1208

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad2b6eb
[cling] Fix thread local storage in the cling JIT
Teemperor Nov 6, 2017
b83f93d
Fix formatting of the TLS commit
Teemperor Nov 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix formatting of the TLS commit
  • Loading branch information
@Teemperor
Teemperor committed Nov 6, 2017
commit b83f93d918ee914df612c4c69921cd9417e4f653
8 changes: 3 additions & 5 deletions interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,9 @@ CreateHostTargetMachine(const clang::CompilerInstance& CI) {
std::string MCPU;
std::string FeaturesStr;

auto TM = std::unique_ptr<TargetMachine>(TheTarget->createTargetMachine(Triple,
MCPU, FeaturesStr,
llvm::TargetOptions(),
Optional<Reloc::Model>(), CMModel,
OptLevel));
auto TM = std::unique_ptr<TargetMachine>(TheTarget->createTargetMachine(
Copy link
Member

@Axel-Naumann Axel-Naumann Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split formatting and functional change into two commits? I'm terrible at filtering white-space parts of diffs from functional ones... Thanks, much appreciated!

Copy link
Contributor Author

@Teemperor Teemperor Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, done.

Triple, MCPU, FeaturesStr, llvm::TargetOptions(),
Optional<Reloc::Model>(), CMModel, OptLevel));
TM->Options.EmulatedTLS = true;
return TM;
}
Expand Down