Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cxxmodules] Also load TreePlayer to fix TDataFrame tests. #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[cxxmodules] Also load TreePlayer to fix TDataFrame tests. #1328
Changes from 1 commit
72ab96167acc36bb580feFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Without modules, many STL and libc headers are automatically provided by ROOT via the attached ROOT PCH. This means that we don't need to have autloading or explicit includes for STL or libc headers when running with the PCH attached. This leads to making user code like this working in ROOT: ```C++ // no includes here that provides assert int foo() { assert(false); } ``` However, as the modules don't come with this big PCH, we are now suddenly in the situation where we can't resolve things such as `assert`. We also can't rely on the normal autoloading of ROOT as those declarations were actually never autoloaded, but just provided by the PCH. To simulate this behavior with modules, we automatically load those headers that we expect to have in the ROOT PCH (which are probably the STL and libc headers).Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing