Skip to content

[modules][cxxmodules] Switch back to umbrella. #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vgvassilev merged 1 commit into from
Nov 20, 2017
Merged

[modules][cxxmodules] Switch back to umbrella. #1348

vgvassilev merged 1 commit into from
Nov 20, 2017

Conversation

@vgvassilev
Copy link
Member

@vgvassilev vgvassilev commented Nov 19, 2017

…modules

@phsft-bot
Copy link

phsft-bot commented Nov 19, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev
Copy link
Member Author

vgvassilev commented Nov 19, 2017

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On

@phsft-bot
Copy link

phsft-bot commented Nov 19, 2017

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Nov 19, 2017

Build failed on slc6/clang_gcc62.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/build/include/module.modulemap:68:29: error: header 'GL/wglew.h' not found

@vgvassilev
Copy link
Member Author

vgvassilev commented Nov 20, 2017

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On

@phsft-bot
Copy link

phsft-bot commented Nov 20, 2017

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Nov 20, 2017

Build failed on slc6/clang_gcc62.
See console output.

Warnings:

  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:

And 100 more

Failing tests:

And 22 more

@vgvassilev
Copy link
Member Author

vgvassilev commented Nov 20, 2017

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=Оn

@phsft-bot
Copy link

phsft-bot commented Nov 20, 2017

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On
How to customize builds

@vgvassilev
Copy link
Member Author

vgvassilev commented Nov 20, 2017

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link

phsft-bot commented Nov 20, 2017

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@Teemperor
Copy link
Contributor

Teemperor commented Nov 20, 2017

Can we also add the warning then to ignore it -Wno-incomplete-umbrella?

@vgvassilev
[modules][cxxmodules] Switch back to umbrella headers.
e2bc290 
The clang issue is resolved, and we do not install wglew.h on non-windows
platforms anymore.
@vgvassilev
Copy link
Member Author

vgvassilev commented Nov 20, 2017

Sure, OTOH, it will be nop because the quoted issue was resolved on our side, too. The issue suggests that we have:

module M1 {
  umbrella "NonExistent" // expected-error here.
  module * { export * }
}

module M2 {
  umbrella "Existent"
  module * { export *}
}

We always create a folder GL, so AFAICT we are not hitting this warning.

Looks like the PR and the commit message were misnomers :( Fixing...

@phsft-bot
Copy link

phsft-bot commented Nov 20, 2017

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@vgvassilev vgvassilev changed the title [modules][cxxmodules] The clang issue is resolved, switch back to sub… [modules][cxxmodules] Switch back to umbrella. Nov 20, 2017
@phsft-bot
Copy link

phsft-bot commented Nov 20, 2017

Build failed on slc6/clang_gcc62.
See console output.

Errors:

  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'
  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'
  • 295/1646 Test Fix GCC 6 compilation (tested on ArchLinux) #188: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 3.39 sec
  • 544/1646 Test ROOTR fixed event loop #446: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.35 sec

And 7 more

Warnings:

  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:

And 100 more

Failing tests:

And 48 more

@vgvassilev vgvassilev merged commit 30f0465 into root-project:master Nov 20, 2017
@vgvassilev vgvassilev deleted the FixGlewModuleMap branch November 20, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@vgvassilev vgvassilev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vgvassilev @phsft-bot @Teemperor