Skip to content

[testing] assert on fwd delcs with modules #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Teemperor wants to merge 1 commit into from
Closed

[testing] assert on fwd delcs with modules #1349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/metacling/src/TCling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,6 +1816,9 @@ void TCling::RegisterModule(const char* modulename,
if (hasHeaderParsingOnDemand && fwdDeclsCode){
// We now parse the forward declarations. All the classes are then modified
// in order for them to have an external lexical storage.
if (fInterpreter->getCI()->getLangOpts().Modules) {
assert(false && "Fwd decls with modules?");
Copy link
Member

@vgvassilev vgvassilev Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably put something like that in TCling::ReadRootmapFile.

}
std::string fwdDeclsCodeLessEnums;
{
// Search for enum forward decls and only declare them if no
Expand Down