[RF] Several improvements to RooClassFactory #13624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
rooclassfactory_1
branch
2 times, most recently
from
179e90f to
515ade0
Compare
guitargeek
force-pushed
the
rooclassfactory_1
branch
from
515ade0 to
ee72f8a
Compare
|
Starting build on |
This is to enable support for expressions representing the complicated amplitudes in partial wave analysis.
This should preserve backwards compatibility, because `const char*` implicitly casts to `std::string`.
If you call `makePdfInstance` or `makeFunctionInstance` twice in a row with the same arguments, the RooClassFactory should not have to recompile anything. This is particularly important to support the jupyter notebook workflow, where the same cell might be run several times. In fact, before this commit, calling the `makeClassInstance` function twice in a row with the same arguments resulted in a crash.
|
Build failed on ROOT-ubuntu2004/python3. |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
lmoneta
approved these changes
Sep 11, 2023
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for this improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sympyfor examplestd::stringinstead of C-style strings