Skip to content

Added Variance Threshold method in DataLoader #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amoudgl wants to merge 3 commits into from
Closed

Added Variance Threshold method in DataLoader #179

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3647b61
Added Variance Threshold transform in DataLoader
amoudgl May 31, 2016
4df39e7
Removed equal to condition for zero-variance cases
amoudgl Jun 1, 2016
159cc9b
Added Doxygen comments
amoudgl Jun 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed equal to condition for zero-variance cases
  • Loading branch information
@amoudgl
amoudgl committed Jun 2, 2016
commit 4df39e7fa0574fcc6513f506252b380b3ee1490d
2 changes: 1 addition & 1 deletion tmva/tmva/src/DataLoader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ TMVA::DataLoader* TMVA::DataLoader::VarTransform(TString trafoDefinition)
for (UInt_t ivar=0; ivar<nvars; ivar++) {
Double_t variance = x0(ivar)/sumOfWeights;
Log() << kINFO << "Variable " << vars[ivar].GetExpression() <<" variance = " << variance << Endl;
if (variance >= threshold)
if (variance > threshold)
transformedloader->AddVariable(vars[ivar].GetExpression(), vars[ivar].GetVarType());
}
CopyDataLoader(transformedloader,this);
Expand Down