Skip to content

[TMVA] Add multiprocessing to parallelise CV #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmoneta merged 10 commits into from
Apr 27, 2018
Merged

[TMVA] Add multiprocessing to parallelise CV #1869

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c996bc5
[TMVA] Add multiprocessing to parallelise CV
ashlaban Apr 17, 2018
cf0eec5
[TMVA] DataSet - Add method DeleteAllResults
ashlaban Apr 18, 2018
d2319c1
[TMVA] Sanity check for DataSet result size.
ashlaban Apr 18, 2018
c9a13f0
[TMVA] Simplify GetTree copying of results
ashlaban Apr 18, 2018
93dc3d2
[TMVA] CV bugfix, remove _all_ results for a fold from DataSet
ashlaban Apr 18, 2018
f7a1e75
[TMVA] Small fixes to TMVACrossValidation.C
ashlaban Apr 18, 2018
693b51f
[TVMA] CV - Fix crash when not using an output file
ashlaban Apr 20, 2018
346d5e7
[TMVA] CV - Add test to verify equality of multiprocessing and single…
ashlaban Apr 20, 2018
72bc7c1
[TMVA] Reorder init order for Config (to supress warnings)
ashlaban Apr 23, 2018
92f063a
[TMVA] CV - Fix warnings
ashlaban Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TVMA] CV - Fix crash when not using an output file
  • Loading branch information
@ashlaban
ashlaban committed Apr 20, 2018
commit 693b51f7ba8bcf3dd6adc4bec74fe36a633e61e8
4 changes: 3 additions & 1 deletion tmva/tmva/src/CrossValidation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,9 @@ void TMVA::CrossValidation::Evaluate()
IMethod *method_interface = fFactory->GetMethod(fDataLoader.get()->GetName(), methodTitle);
MethodCrossValidation *method = dynamic_cast<MethodCrossValidation *>(method_interface);

fFactory->WriteDataInformation(method->fDataSetInfo);
if (fOutputFile) {
fFactory->WriteDataInformation(method->fDataSetInfo);
}

Event::SetIsTraining(kTRUE);
method->TrainMethod();
Expand Down