Skip to content

Conversation

@pcanal
Copy link
Member

@pcanal pcanal commented May 14, 2025

We 'could' enable the test coverage for all pull (master) request but ... it takes 2 or 3 hours to run the tests.
So we introduce a label 'test coverage' to enable it explicitly for a PR.

Once the nightly runs, we will see the result at https://app.codecov.io/github/root-project/root/tree/master.

From there we can see the results obtained for running at part of this PR and we get 33.74% so far ...

@pcanal pcanal self-assigned this May 14, 2025
@pcanal pcanal added the in:CI label May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.15%. Comparing base (7b9f26e) to head (fd9588b).
Report is 12790 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18710      +/-   ##
==========================================
+ Coverage   31.76%   33.15%   +1.39%     
==========================================
  Files        3616     4029     +413     
  Lines      547093   568830   +21737     
  Branches   250259   262983   +12724     
==========================================
+ Hits       173805   188623   +14818     
+ Misses     270494   263120    -7374     
- Partials   102794   117087   +14293     
Flag Coverage Δ
unittests 33.15% <ø> (+1.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcanal pcanal force-pushed the master_code_coverage branch 3 times, most recently from 94c5f47 to 642fad6 Compare May 16, 2025 22:40
@pcanal pcanal force-pushed the master_code_coverage branch 16 times, most recently from 085abc1 to d827ab2 Compare May 21, 2025 20:01
@pcanal pcanal force-pushed the master_code_coverage branch 9 times, most recently from 3cdc8ae to 9b1c25b Compare May 22, 2025 16:24
@pcanal pcanal changed the title [skip-ci][ci] Testing code coverage workflow [ci] Testing code coverage workflow May 22, 2025
@pcanal pcanal force-pushed the master_code_coverage branch 3 times, most recently from 20faa7f to f533acd Compare May 22, 2025 16:43
@pcanal pcanal added the test coverage Run the test code coverage workflow on this PR label May 22, 2025
@pcanal pcanal closed this May 22, 2025
@pcanal pcanal reopened this May 22, 2025
pcanal added 6 commits May 22, 2025 11:50
Error: .github/workflows/root-ci-config/build_utils.py:258:9: E722 Do not use bare
Error: .github/workflows/root-ci-config/build_utils.py:263:19: E701 Multiple statements on one line (colon)
Add option for binaries upload, build type choice and incremental builds.
@pcanal pcanal force-pushed the master_code_coverage branch from f533acd to fd9588b Compare May 22, 2025 16:50
@pcanal pcanal marked this pull request as ready for review May 22, 2025 16:51
@pcanal pcanal requested review from bellenot and dpiparo as code owners May 22, 2025 16:51
@pcanal pcanal requested a review from hageboeck May 22, 2025 16:51
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments from my side. Good work!

@pcanal pcanal merged commit 5dbc961 into root-project:master May 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:CI test coverage Run the test code coverage workflow on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants