-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ci] Testing code coverage workflow #18710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18710 +/- ##
==========================================
+ Coverage 31.76% 33.15% +1.39%
==========================================
Files 3616 4029 +413
Lines 547093 568830 +21737
Branches 250259 262983 +12724
==========================================
+ Hits 173805 188623 +14818
+ Misses 270494 263120 -7374
- Partials 102794 117087 +14293
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
94c5f47 to
642fad6
Compare
085abc1 to
d827ab2
Compare
3cdc8ae to
9b1c25b
Compare
20faa7f to
f533acd
Compare
Error: .github/workflows/root-ci-config/build_utils.py:258:9: E722 Do not use bare Error: .github/workflows/root-ci-config/build_utils.py:263:19: E701 Multiple statements on one line (colon)
Add option for binaries upload, build type choice and incremental builds.
f533acd to
fd9588b
Compare
hageboeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No further comments from my side. Good work!
We 'could' enable the test coverage for all pull (master) request but ... it takes 2 or 3 hours to run the tests.
So we introduce a label 'test coverage' to enable it explicitly for a PR.
Once the nightly runs, we will see the result at https://app.codecov.io/github/root-project/root/tree/master.
From there we can see the results obtained for running at part of this PR and we get 33.74% so far ...