[cling] Deduplicate cling::utils::TypeName::GetFullyQualifiedName

[devajithvs]

This Pull request:

Work in Progress: Uses upstream GetFullyQualifiedName but has diverged quite a bit and there are failing tests locally

Changes or fixes:

Checklist:

• tested changes locally
• updated the docs (if necessary)

This PR fixes #18622

[guitargeek]

Ha, that's funny! I was just touching the same code because there was an easy Jira issue to fix:

• [cling] Update policy for GetFullyQualifiedName in cling utils #19292

Maybe you can take the unit test from that PR and put it here too? The reproducer should also be fixed by what you're doing here. Or we merge my PR before? As you prefer.

[devajithvs]

Ha, that's funny! I was just touching the same code because there was an easy Jira issue to fix:

• [cling] Update policy for GetFullyQualifiedName in cling utils #19292

Maybe you can take the unit test from that PR and put it here too? The reproducer should also be fixed by what you're doing here. Or we merge my PR before? As you prefer.

Yes, I saw your PR. I think it’s better that your PR is merged first. I need to look a bit more into the failing cases.

[github-actions]

Test Results

    20 files      20 suites   3d 5h 37m 3s ⏱️
 3 192 tests  3 141 ✅ 0 💤  51 ❌
62 241 runs  62 099 ✅ 0 💤 142 ❌

For more details on these failures, see this check.

Results for commit 99b850c.

[guitargeek]

Well, my PR has the same problems.

Could it be a clang upstream problem? I noticed that even with LLVM 20, printing out the qual type of the std::vector<T>::at method is missing the template arguments of the function argument types:

std::vector<int>::reference (std::vector<int>::*)(std::vector::size_type)

I used the following policy when printing:

PrintingPolicy Policy(Context->getPrintingPolicy());

Policy.FullyQualifiedName = true;
Policy.SuppressElaboration = true;

Maybe this should be fixed upstream?

[ferdymercury]

Related: #999