[ntuple] Default RBulkValues move constructor and assignment
#19832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All members are moveable and there seems to be no custom code.
silverweed
reviewed
Sep 5, 2025
| fFirstIndex(other.fFirstIndex) | ||
| { | ||
| std::swap(fDeleter, other.fDeleter); | ||
| std::swap(fValues, other.fValues); |
There was a problem hiding this comment.
I think this swap is necessary, otherwise the pointer may just get copied and we'd end up freeing the values twice in the destructor, no?
There was a problem hiding this comment.
Hm, that's a good point - I found this code because our coverage report says we're not testing it at all, so maybe we should do this and see.
Test Results 20 files 20 suites 4d 0h 23m 41s ⏱️ For more details on these failures, see this check. Results for commit 6056627. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All members are moveable and there seems to be no custom code.