[core] Use version script to hide symbols in libCling #19923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use -fvisibility=hidden and -fvisibility-inlines-hidden to generate symbols that are not exported from the shared object. However, these two options don't apply for non-inline template instantiations, which can still cause problems when a STL container is instantiated with an LLVM type that may change size between LLVM versions. Fixes root-project#19889
1 task
Test Results 21 files 21 suites 3d 11h 46m 43s ⏱️ For more details on these failures, see this check. Results for commit 1114df8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use
-fvisibility=hiddenand-fvisibility-inlines-hiddento generate symbols that are not exported from the shared object. However, these two options don't apply for non-inline template instantiations, which can still cause problems when a STL container is instantiated with an LLVM type that may change size between LLVM versions.Fixes #19889