Skip to content

More comments for 238, basket size optimization #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gemmeren wants to merge 3 commits into from
Closed

More comments for 238, basket size optimization #258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad9d7f4
Update basket optimization
Sep 7, 2016
9fe4e47
Add comment, fix typo
Sep 8, 2016
37cc446
More comment, release notes
Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment, fix typo
  • Loading branch information
Peter Van Gemmeren committed Sep 8, 2016
commit 9fe4e47d104118752e1235ffb2c094e865d0674c
5 changes: 3 additions & 2 deletions tree/tree/src/TTree.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6582,9 +6582,10 @@ void TTree::OptimizeBaskets(ULong64_t maxMemory, Float_t minComp, Option_t *opti
UInt_t newBsize = UInt_t(bsize);
if (pass) { // only on the second pass so that it doesn't interfere with scaling
if (branch->GetBasket(0) != 0) {
newBsize = newBsize + (branch->GetBasket(0)->GetNevBuf() * sizeof(Int_t) * 2); // make room for meta dat
newBsize = newBsize + (branch->GetBasket(0)->GetNevBuf() * sizeof(Int_t) * 2); // make room for meta data
}
newBsize = newBsize - newBsize%512 + 512; // rounds up
// rounds up, increases basket size to ensure all entries fit into single basket as intended
newBsize = newBsize - newBsize%512 + 512;
}
if (newBsize < sizeOfOneEntry) newBsize = sizeOfOneEntry;
if (newBsize < bmin) newBsize = bmin;
Expand Down