Skip to content

[cxxmodules] Only remove "lib" prefix if it exists! From Yuka and me. #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vgvassilev wants to merge 1 commit into from
Closed

[cxxmodules] Only remove "lib" prefix if it exists! From Yuka and me. #2716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/metacling/src/TCling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1986,7 +1986,11 @@ void TCling::RegisterModule(const char* modulename,

bool ModuleWasSuccessfullyLoaded = false;
if (hasCxxModule) {
std::string ModuleName = llvm::StringRef(modulename).substr(3).str();
std::string ModuleName = modulename;
// Remove lib from modulename if any
if (llvm::StringRef(modulename).startswith("lib"))
ModuleName = modulename + 3;

// FIXME: We should only complain for modules which we know to exist. For example, we should not complain about
// modules such as GenVector32 because it needs to fall back to GenVector.
ModuleWasSuccessfullyLoaded = LoadModule(ModuleName, *fInterpreter, /*Complain=*/ false);
Expand Down