Skip to content

Conversation

@vgvassilev
Copy link
Member

We assumed that we will always have module file and unconditionally disable
header parsing on demand. However, the major use-case is gradual migration
to modules. In this scenario (tested by root-meta-fwdDecls-fwdDeclarations),
we have a dictionary which has no module file and still relies on the old
behavior. This can realistically happen when users gradually migrate to
modules. For example, we have modules-aware ROOT and untouched third party
code.

This patch enables header parsing on demand when we have no module file
available.

We assumed that we will always have module file and unconditionally disable
header parsing on demand. However, the major use-case is gradual migration
to modules. In this scenario (tested by root-meta-fwdDecls-fwdDeclarations),
we have a dictionary which has no module file and still relies on the old
behavior. This can realistically happen when users gradually migrate to
modules. For example, we have modules-aware ROOT and untouched third party
code.

This patch enables header parsing on demand when we have no module file
available.
@vgvassilev vgvassilev requested a review from pcanal as a code owner September 30, 2018 20:10
@phsft-bot
Copy link

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

vgvassilev added a commit to vgvassilev/roottest that referenced this pull request Sep 30, 2018
@vgvassilev
Copy link
Member Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

@vgvassilev
Copy link
Member Author

This is due to cdash upload issue, otherwise test seems to be fixed.

vgvassilev added a commit to root-project/roottest that referenced this pull request Oct 1, 2018
@vgvassilev vgvassilev merged commit 8ea5bf7 into root-project:master Oct 1, 2018
@vgvassilev vgvassilev deleted the cxxmodules-fix-fwdDeclarations branch October 1, 2018 12:20
vgvassilev added a commit to vgvassilev/roottest that referenced this pull request Oct 2, 2018
vgvassilev added a commit to root-project/roottest that referenced this pull request Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants