Skip to content

Add a class to perform compensate summation #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 6 commits into from
Apr 6, 2017
Merged

Add a class to perform compensate summation #372

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a334562
Add a class to perform the compensate summation
xvallspl Feb 27, 2017
4bbf52a
Move KahanSum to Math/Util.h
xvallspl Feb 27, 2017
5f81942
Fix indentation :art:
xvallspl Feb 27, 2017
ce1c9ad
Add test for the compensate summation
xvallspl Feb 28, 2017
1f0f1e6
Fixed the summation for non-real types
xvallspl Mar 1, 2017
c3fee5b
Apply clang-format :art:
xvallspl Apr 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed the summation for non-real types
  • Loading branch information
@xvallspl
xvallspl committed Apr 6, 2017
commit 1f0f1e663fa726bd3f6259e16382bb1d8b95d21b
9 changes: 5 additions & 4 deletions math/mathcore/inc/Math/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,21 +86,22 @@ namespace ROOT {
this->Add(e);
}

static double Accumulate(const std::vector<T> &elements)
static T Accumulate(const std::vector<T> &elements)
{

KahanSum init;
init.Add(elements);
return init.sum;
}

double Result()
T Result()
{
return sum;
}

private:
double sum = 0.;
double correction = 0.;
T sum{};
T correction{};
};

} // end namespace Math
Expand Down