Fix relocation problems in Aarch64 (backport) #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
Let's wait until the patch is landed. I believe this is a matter of hours. |
Member
|
I take that back. Why is the revision of LLVM which contains this patch? |
Contributor
|
It's in the patch: https://reviews.llvm.org/D27609 or better https://reviews.llvm.org/rL289880 |
Member
|
Ok, LGTM and as long as @karies is happy we can merge this. |
vgvassilev
approved these changes
Mar 15, 2017
Axel-Naumann
approved these changes
Mar 16, 2017
Member
Axel-Naumann
left a comment
Axel-Naumann
left a comment
There was a problem hiding this comment.
👍 @vgvassilev - you can do the merge into ROOT; I will upload to our llvm fork later.
Member
|
@phsft-bot build! |
vgvassilev
pushed a commit
that referenced
this pull request
Mar 17, 2017
gganis
pushed a commit
to gganis/root
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://sft.its.cern.ch/jira/browse/ROOT-8702
The fix is taken from Fedora's patch to their LLVM package:
http://pkgs.fedoraproject.org/cgit/rpms/llvm.git/tree/0001-Fix-R_AARCH64_MOVW_UABS_G3-relocation.patch
This is in turn based on the changes from the upstream change:
https://reviews.llvm.org/D27609