Find scope parser raii #4358

pcanal · 2019-09-06T16:08:12Z

Improve the push/pop/RAII used in findScope for the Parser and lexer.
Also fixes several deficiencies 'revealed' by the 'failing' RAII

This fixes [https://sft.its.cern.ch/jira/browse/ROOT-10224]

Also improve error recovery (don't assign/keep an invalid ClassInfo). We avoid the lookup by doing it only when we have a class with an opaque typedef (Double32_t) ... except that we don't know how to find them yet (at least not in a performant way).

phsft-bot · 2019-09-06T16:08:27Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

pcanal · 2019-09-06T16:09:18Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2019-09-06T16:09:25Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

In particular the CachedTokens need to be pushed/pop or otherwise give misleading information. This fixes ROOT-10224.

phsft-bot · 2019-09-06T16:21:28Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-09-06T16:36:01Z

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Failing tests:

phsft-bot · 2019-09-06T16:41:12Z

Build failed on mac1014/cxx17.
See console output.

Errors:

958/1991 Test Added resetting flag to ensure that each Jupyter cell is independent … #866: tutorial-v7-concurrentfill.cxx ....................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.01 sec
969/1991 Test [cxxmodules] Removed libXXX.so from C++ module names. #878: tutorial-v7-perf.cxx ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.91 sec
971/1991 Test Fixed CMake formatting for cxxmodules option. #879: tutorial-v7-perfcomp.cxx ..........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.00 sec
972/1991 Test Fix y-error bars for TGraphAsymmErrors(TH1) #880: tutorial-v7-simple.cxx ............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.01 sec

Failing tests:

phsft-bot · 2019-09-06T16:48:45Z

Build failed on ROOT-fedora27/noimt.
See console output.

Failing tests:

phsft-bot · 2019-09-06T17:03:05Z

Build failed on ROOT-fedora29/python3.
See console output.

Failing tests:

phsft-bot · 2019-09-06T17:40:14Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

I.e. don't reuse a variable for a slightly different menaing.

…Info)

phsft-bot · 2019-09-06T21:00:48Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-09-06T21:32:50Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

projectroot.roottest.root.multicore.roottest_root_multicore_exectsinclude

phsft-bot · 2019-09-06T21:58:42Z

Build failed on mac1014/cxx17.
See console output.

Errors:

961/1991 Test Added resetting flag to ensure that each Jupyter cell is independent … #866: tutorial-v7-concurrentfill.cxx ....................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.99 sec
971/1991 Test [cxxmodules] Removed libXXX.so from C++ module names. #878: tutorial-v7-perf.cxx ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.73 sec
972/1991 Test Fixed CMake formatting for cxxmodules option. #879: tutorial-v7-perfcomp.cxx ..........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.78 sec
974/1991 Test Fix y-error bars for TGraphAsymmErrors(TH1) #880: tutorial-v7-simple.cxx ............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.89 sec

Failing tests:

pcanal · 2019-09-09T15:16:03Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2019-09-09T15:16:14Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-09-09T15:46:35Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

projectroot.roottest.root.multicore.roottest_root_multicore_exectsinclude

phsft-bot · 2019-09-09T16:12:33Z

Build failed on mac1014/cxx17.
See console output.

Errors:

962/1991 Test Added resetting flag to ensure that each Jupyter cell is independent … #866: tutorial-v7-concurrentfill.cxx ....................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.84 sec
971/1991 Test [cxxmodules] Removed libXXX.so from C++ module names. #878: tutorial-v7-perf.cxx ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.20 sec
973/1991 Test Fixed CMake formatting for cxxmodules option. #879: tutorial-v7-perfcomp.cxx ..........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.28 sec
975/1991 Test Fix y-error bars for TGraphAsymmErrors(TH1) #880: tutorial-v7-simple.cxx ............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.82 sec

Failing tests:

pcanal · 2019-09-09T17:00:11Z

The error are pre-existing (the v7 macos error have been fixed by another PR).

pcanal added 6 commits September 6, 2019 10:16

Correct the TClass state when created from a ClassInfo

b770487

Move declaration next to use

1d98c55

Add comment explanation the choice of name used in recording.

6f65ddc

Use fully qualified name as expected further

bcf2864

Don't record an invalid ClassInfo

ada6166

pcanal added the do not merge label Sep 6, 2019

pcanal requested a review from Axel-Naumann as a code owner September 6, 2019 16:08

Expand StartParsingRAII

efa1c77

In particular the CachedTokens need to be pushed/pop or otherwise give misleading information. This fixes ROOT-10224.

pcanal force-pushed the findScopeParserRAII branch from 9f75a9a to efa1c77 Compare September 6, 2019 16:21

[NFC] Clang-formatting

ab78486

pcanal added 4 commits September 6, 2019 15:41

Improve type safety

12eb144

In UpdateClassInfoWithDecl, ignore incomplete definition.

59ddae9

In UpdateClassInfoWithDecl, improve semantic use of variable name.

d739e7f

I.e. don't reuse a variable for a slightly different menaing.

In UpdateClassInfoWithDecl fix support for namespace (in RefreshClass…

609c965

…Info)

pcanal changed the title ~~[WIP] Find scope parser raii~~ Find scope parser raii Sep 9, 2019

pcanal merged commit d5a2083 into root-project:master Sep 9, 2019

pcanal deleted the findScopeParserRAII branch September 9, 2019 17:21

Find scope parser raii #4358

Find scope parser raii #4358

Uh oh!

Conversation

pcanal commented Sep 6, 2019

Uh oh!

phsft-bot commented Sep 6, 2019

Uh oh!

pcanal commented Sep 6, 2019

Uh oh!

phsft-bot commented Sep 6, 2019

Uh oh!

phsft-bot commented Sep 6, 2019

Uh oh!

phsft-bot commented Sep 6, 2019

Failing tests:

Uh oh!

phsft-bot commented Sep 6, 2019

Errors:

Failing tests:

Uh oh!

phsft-bot commented Sep 6, 2019

Failing tests:

Uh oh!

phsft-bot commented Sep 6, 2019

Failing tests:

Uh oh!

phsft-bot commented Sep 6, 2019

Failing tests:

Uh oh!

phsft-bot commented Sep 6, 2019

Uh oh!

phsft-bot commented Sep 6, 2019

Failing tests:

Uh oh!

phsft-bot commented Sep 6, 2019

Errors:

Failing tests:

Uh oh!

pcanal commented Sep 9, 2019

Uh oh!

phsft-bot commented Sep 9, 2019

Uh oh!

phsft-bot commented Sep 9, 2019

Failing tests:

Uh oh!

phsft-bot commented Sep 9, 2019

Errors:

Failing tests:

Uh oh!

pcanal commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants