Skip to content

[TDF] optimizations to the event loop #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eguiraud wants to merge 7 commits into from
Closed

[TDF] optimizations to the event loop #442

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68b3066
[TDF] Unique_ptr instead of shared_ptr in TDataFrameBranch
eguiraud Mar 19, 2017
ab88b9f
[TDF] Add missing header
eguiraud Mar 19, 2017
cac3fad
[TDF] Remove all usages of shared_ptrs in the event loop
eguiraud Mar 16, 2017
c193553
[TDF] clang-format
eguiraud Mar 19, 2017
f8d1fbb
[TDF] Remove now unused TDataFrameImpl::GetTmpBranchValue
eguiraud Mar 19, 2017
2a9d6ab
[TDF] Minor text fixes
eguiraud Mar 19, 2017
ea87b95
[TDF] Fix "unused parameter" warnings on mac
eguiraud Mar 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TDF] Remove now unused TDataFrameImpl::GetTmpBranchValue
  • Loading branch information
@eguiraud
eguiraud committed Mar 19, 2017
commit f8d1fbb2fc6600fd224ad7ab03efdb7a512ca35d
1 change: 0 additions & 1 deletion tree/treeplayer/inc/ROOT/TDFNodes.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ public:
TTree * GetTree() const;
TDataFrameBranchBase *GetBookedBranch(const std::string &name) const;
const std::map<std::string, TmpBranchBasePtr_t> &GetBookedBranches() const { return fBookedBranches; }
void *GetTmpBranchValue(const std::string &branch, unsigned int slot);
::TDirectory *GetDirectory() const;
std::string GetTreeName() const;
void Book(const ActionBasePtr_t &actionPtr);
Expand Down
5 changes: 0 additions & 5 deletions tree/treeplayer/src/TDFNodes.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,6 @@ TDataFrameBranchBase *TDataFrameImpl::GetBookedBranch(const std::string &name) c
return it == fBookedBranches.end() ? nullptr : it->second.get();
}

void *TDataFrameImpl::GetTmpBranchValue(const std::string &branch, unsigned int slot)
{
return fBookedBranches.at(branch)->GetValuePtr(slot);
}

TDirectory *TDataFrameImpl::GetDirectory() const
{
return fDirPtr;
Expand Down