Skip to content

Fix inf loop in test on arm #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Mar 27, 2017
Merged

Fix inf loop in test on arm #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix inf loop in test on arm 
There was an infinite loop on the arm platform when running
TMVAMulticlass.root. When compiling with the -ffast-math flag,
sometimes a nan would be generated.
  • Loading branch information
@ashlaban
ashlaban committed Mar 20, 2017
commit 5619a8ccbfb803ad881fdbb163f5e1b14307f1fd
2 changes: 1 addition & 1 deletion tmva/tmva/src/ResultsMulticlass.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Double_t TMVA::ResultsMulticlass::EstimatorFunction( std::vector<Double_t> & cut
Float_t effTimesPur = eff*pur;

Float_t toMinimize = std::numeric_limits<float>::max();
if( effTimesPur > 0 )
if (effTimesPur > std::numeric_limits<float>::min())
toMinimize = 1./(effTimesPur); // we want to minimize 1/efficiency*purity

fAchievableEff.at(fClassToOptimize) = eff;
Expand Down