Add support for gtest if testing is enabled.

Add unit tests for TQObject as an example for further reference.

cmake/modules/RootNewMacros.cmake

@@ -1078,6 +1078,22 @@ function(ROOT_ADD_TEST test)
 
 endfunction()
 
+#----------------------------------------------------------------------------
+# function ROOT_ADD_GTEST(<testsuite> <name> LIBRARIES)
+#
+function(ROOT_ADD_GTEST test_suite test_name)
+  CMAKE_PARSE_ARGUMENTS(ARG "" "" "LIBRARIES" ${ARGN})
+
+  include_directories(${GTEST_INCLUDE_DIR} ${GMOCK_INCLUDE_DIR})
+
+  # Note we cannot use ROOT_EXECUTABLE because it requires to pass LIBRARIES to link with.
+  # The test suites should chose this in their specific CMakeLists.txt file.
+  ROOT_EXECUTABLE(${test_suite} ${test_name} LIBRARIES ${ARG_LIBRARIES})
+  target_link_libraries(${test_suite} gtest gtest_main gmock gmock_main)
+  ROOT_ADD_TEST(gtest-${test_suite} COMMAND ${test_suite})
+endfunction()
+
+
 #----------------------------------------------------------------------------
 # ROOT_ADD_TEST_SUBDIRECTORY( <name> )
 #----------------------------------------------------------------------------

cmake/modules/SearchInstalledSoftware.cmake

@@ -1371,6 +1371,59 @@ if(tmva AND imt)
   find_package(BLAS)
 endif()
 
+
+#---Download googletest--------------------------------------------------------------
+if (testing)
+  # FIXME: Remove our version of gtest in roottest. We can reuse this one.
+  # Add gtest
+  # http://stackoverflow.com/questions/9689183/cmake-googletest
+  ExternalProject_Add(
+    googletest
+    URL https://github.com/google/googletest/archive/release-1.8.0.zip
+    # TIMEOUT 10
+    # # Force separate output paths for debug and release builds to allow easy
+    # # identification of correct lib in subsequent TARGET_LINK_LIBRARIES commands
+    # CMAKE_ARGS -DCMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG:PATH=DebugLibs
+    #            -DCMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELEASE:PATH=ReleaseLibs
+    #            -Dgtest_force_shared_crt=ON
+    # Disable install step
+    INSTALL_COMMAND ""
+    # Wrap download, configure and build steps in a script to log output
+    LOG_DOWNLOAD ON
+    LOG_CONFIGURE ON
+    LOG_BUILD ON)
+
+  # Specify include dirs for gtest and gmock
+  ExternalProject_Get_Property(googletest source_dir)
+  set(GTEST_INCLUDE_DIR ${source_dir}/googletest/include)
+  set(GMOCK_INCLUDE_DIR ${source_dir}/googlemock/include)
+
+  # Libraries
+  ExternalProject_Get_Property(googletest binary_dir)
+  set(_G_LIBRARY_PATH ${binary_dir}/googlemock/)
+
+  # gtest
+  add_library(gtest IMPORTED STATIC GLOBAL)
+  set_property(TARGET gtest PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/gtest/libgtest.a)
+  add_dependencies(gtest googletest)
+
+  # gtest_main
+  add_library(gtest_main IMPORTED STATIC GLOBAL)
+  set_property(TARGET gtest_main PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/gtest/libgtest_main.a)
+  add_dependencies(gtest_main googletest)
+
+  # gmock
+  add_library(gmock IMPORTED STATIC GLOBAL)
+  set_property(TARGET gmock PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/libgmock.a)
+  add_dependencies(gmock googletest)
+
+  # gmock_main
+  add_library(gmock_main IMPORTED STATIC GLOBAL)
+  set_property(TARGET gmock_main PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/libgmock_main.a)
+  add_dependencies(gmock_main googletest)
+
+endif()
+
 #---Report non implemented options---------------------------------------------------
 foreach(opt afs glite sapdb srp)
   if(${opt})

core/CMakeLists.txt

@@ -16,6 +16,10 @@ add_subdirectory(thread)
 add_subdirectory(zip)
 add_subdirectory(lzma)
 
+if(testing)
+  ROOT_ADD_TEST_SUBDIRECTORY(test)
+endif()
+
 if(NOT WIN32)
   add_subdirectory(newdelete)
 endif()

core/test/CMakeLists.txt

@@ -0,0 +1,5 @@
+############################################################################
+# CMakeLists.txt file for testing ROOT (global) core package
+############################################################################
+
+add_subdirectory(base)

core/test/base/CMakeLists.txt

@@ -0,0 +1,6 @@
+set (link_libs Core)
+
+ROOT_ADD_GTEST(CoreBaseTests
+  TQObjectTests.cxx
+  LIBRARIES ${link_libs}
+  )

core/test/base/TQObjectTests.cxx

@@ -0,0 +1,63 @@
+#include "gtest/gtest.h"
+#include "gmock/gmock.h"
+
+#include "Rtypes.h"
+#include "TQObject.h"
+#include "TQConnection.h"
+
+#include "RQ_OBJECT.h"
+
+// FIXME: We should think of a common place to put the mock objects.
+class TQConnectionMock : public TQConnection {
+public:
+   virtual ~TQConnectionMock() {} // gmock requires it for cleanup on shutdown.
+   MOCK_METHOD1(SetArg, void(Long_t param));
+   MOCK_METHOD1(SetArg, void(ULong_t param));
+   MOCK_METHOD1(SetArg, void(Float_t param));
+   MOCK_METHOD1(SetArg, void(Double_t param));
+   MOCK_METHOD1(SetArg, void(Long64_t param));
+   MOCK_METHOD1(SetArg, void(ULong64_t param));
+   MOCK_METHOD1(SetArg, void(const char *param));
+   MOCK_METHOD2(SetArg, void(const Long_t *params, Int_t nparam /* = -1*/));
+
+   MOCK_METHOD0(SendSignal, void());
+
+   // MOCK_METHOD1(SendSignal, void());
+};
+
+#define Stringify(s) Stringifyx(s)
+#define Stringifyx(s) #s
+
+#define DICT_CLASS                                                           \
+   class RQ_OBJECTTester : public TQObject {                                 \
+      /* This will expand, adding signal/slot support to this class */       \
+      RQ_OBJECT("RQ_OBJECTTester");                                          \
+      Int_t fValue = 0;                                                      \
+                                                                             \
+   public:                                                                   \
+      void SetValue(Int_t value)                                             \
+      {                                                                      \
+         /* to prevent infinite looping in the case of cyclic connections */ \
+         if (value != fValue) {                                              \
+            fValue = value;                                                  \
+            Emit("SetValue(Int_t)", fValue);                                 \
+         }                                                                   \
+      }                                                                      \
+      void PrintValue() const { printf("value=%d\n", fValue); }              \
+      Int_t GetValue() const { return fValue; }                              \
+   };
+
+DICT_CLASS;
+
+TEST(TQObject, Emit)
+{
+   gInterpreter->ProcessLine(Stringify(DICT_CLASS));
+   RQ_OBJECTTester a;
+   RQ_OBJECTTester b;
+   a.Connect("SetValue(Int_t)", "RQ_OBJECTTester", &b, "SetValue(Int_t)");
+
+   EXPECT_EQ(0, b.GetValue());
+
+   a.SetValue(1);
+   EXPECT_EQ(1, b.GetValue());
+}