Skip to content

[cling] Keep deferred decls #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Axel-Naumann wants to merge 3 commits into from
Closed

[cling] Keep deferred decls #456

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ad0cdf
Do not remove DeferredDecls when they become EmittedDeferredDecls.
Axel-Naumann Mar 3, 2017
0e9172b
We can now remove leftover symbols.
Axel-Naumann Mar 6, 2017
89b3b13
Rip out EmittedDeferredDecls; decls are now kept in DeferredDecls.
Axel-Naumann Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not remove DeferredDecls when they become EmittedDeferredDecls. 
Needs an appropriate "if" on a future LangOpts::incremantallyProcessing.
  • Loading branch information
@Axel-Naumann
Axel-Naumann committed Mar 22, 2017
commit 2ad0cdfdbee38375b8159223bf1cf43f02397c98
4 changes: 2 additions & 2 deletions interpreter/llvm/src/tools/clang/lib/CodeGen/CodeGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ CodeGenModule::GetOrCreateLLVMFunction(StringRef MangledName,
// don't need it anymore).
addDeferredDeclToEmit(F, DDI->second);
EmittedDeferredDecls[F] = std::make_pair(DDI->first, DDI->second);
DeferredDecls.erase(DDI);
//DeferredDecls.erase(DDI);

// Otherwise, there are cases we have to worry about where we're
// using a declaration for which we must emit a definition but where
Expand Down Expand Up @@ -2169,7 +2169,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName,
// list, and remove it from DeferredDecls (since we don't need it anymore).
addDeferredDeclToEmit(GV, DDI->second);
EmittedDeferredDecls[GV] = std::make_pair(DDI->first, DDI->second);
DeferredDecls.erase(DDI);
//DeferredDecls.erase(DDI);
}

// Handle things which are present even on external declarations.
Expand Down