Don't search default paths when looking for numpy #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmakes find_path() function looks first in system directories and then in the directories listed by PATHS. So if there are numpy includes in /usr/include they will be found first which can break the build. One way to fix this could be to use HINTS instead of PATHS which will be searched before the system paths. But in this case we know which directory we want as we got it from python so let's just skip all other paths and just look there by adding NO_DEFAULT_PATH.
|
Can one of the admins verify this patch? |
Contributor
|
@phsft-bot build |
|
Starting build on |
Contributor
|
Thanks very much! |
This was referenced Nov 14, 2017
This was referenced Oct 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmakes
find_path()function looks first in system directories and thenin the directories listed by
PATHS. So if there are numpy includes in/usr/includethey will be found first which can break the build.One way to fix this could be to use
HINTSinstead ofPATHSwhich will besearched before the system paths. But in this case we know which
directory we want as we got it from python so let's just skip all other
paths and just look there by adding
NO_DEFAULT_PATH.