Keep clang-tidy modernize-use-bool-literals happy #472
Conversation
clang-tidy with `modernize-use-bool-literals` complains about the fact that 0 is used in place of false. Given I assume there is no particular reason for using `0` rather than `false`, I suggest to change it to avoid the false positives.
|
Can one of the admins verify this patch? |
|
Uh? Why is travis failing? |
|
The changes don't comply with ROOT's coding conventions. Please see the diff (clicking on Details). |
|
I'd be interested to see this check applied for everything in core (and maybe latter for the other parts of the codebase). |
|
Well, to tell the truth it's the current TError code which does not comply to the coding conventions. If I understand correctly, the issue is actually due to the misaligned |
|
@phsft-bot build! @ktf, thanks! |
|
Starting build on |
|
...and apologies for Travis claiming that you broke the coding convention. Thanks for fixing it, though! :-) (But next time just complain, please: as you pointed out, this is absolutely not your responsibility to fix existing violations of the coding convention.) And I'm working on the (unrelated) build fixes... |
|
The clang-format tool considers a line in the context of C++, so the backslashes told it this was a single line :) All looks good to me! I will merge this PR. |
|
@vgvassilev ah, right. That explains it. @Axel-Naumann no worries, fixing these kind of things is kinda relaxing... ;-) |
* Keep clang-tidy modernize-use-bool-literals happy clang-tidy with `modernize-use-bool-literals` complains about the fact that 0 is used in place of false. Given I assume there is no particular reason for using `0` rather than `false`, I suggest to change it to avoid the false positives. * Align TError.h to ROOT coding conventions
4 participants
clang-tidy with
modernize-use-bool-literalscomplains about the fact that 0 is used in place of false. Given I assume there is no particular reason for using0rather thanfalse, I suggest to change it to avoid the false positives.