Skip to content

Moved TMath's fundamental constants to TMathBase #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xvallspl wants to merge 3 commits into from
Closed

Moved TMath's fundamental constants to TMathBase #475

xvallspl wants to merge 3 commits into from

Conversation

@xvallspl
Copy link
Contributor

@xvallspl xvallspl commented Mar 31, 2017

No description provided.

@phsft-bot
Copy link

phsft-bot commented Mar 31, 2017

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@vgvassilev
Copy link
Member

vgvassilev commented Mar 31, 2017

It seems most of the inlines could turn into constexprs.

@xvallspl
Copy link
Contributor Author

xvallspl commented Mar 31, 2017 via email

@xvallspl xvallspl changed the title Moved TMath's fundamental constants to TMathBase [WIP] Moved TMath's fundamental constants to TMathBase Mar 31, 2017
@xvallspl
Made inline constant functions constexpr
d3b790c 
Doesn't change much, but gives more information to the user
@phsft-bot
Copy link

phsft-bot commented Mar 31, 2017

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@vgvassilev
Copy link
Member

vgvassilev commented Mar 31, 2017

This looks good to me, modulo the clang-format unhappiness.

@phsft-bot
Copy link

phsft-bot commented Apr 3, 2017

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

1 similar comment
@phsft-bot
Copy link

phsft-bot commented Apr 3, 2017

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@xvallspl xvallspl changed the title [WIP] Moved TMath's fundamental constants to TMathBase Moved TMath's fundamental constants to TMathBase Apr 3, 2017
@lmoneta
Copy link
Member

lmoneta commented Apr 4, 2017

I don;t agree with this PR.
I think Math constants should remain in Math.h and stays in Mathcore. TMathBase should be minimal and not contain those math constants.

I see this is done only for a use of TMath::Pi in TTimeStamp. I would just hardcoded there and avoid this PR

Lorenzo

@xvallspl
Copy link
Contributor Author

xvallspl commented Apr 6, 2017

This won't be applied

@xvallspl xvallspl closed this Apr 6, 2017
@phsft-bot phsft-bot mentioned this pull request Jun 30, 2019
Merged
@phsft-bot phsft-bot mentioned this pull request Jul 6, 2022
Closed
@phsft-bot phsft-bot mentioned this pull request Jul 15, 2022
Closed
guitargeek pushed a commit to guitargeek/root that referenced this pull request Apr 28, 2025
@oshadura
Update gtest to latest version 1.10.0 (sync) (root-project#475)
8d18d26 
* Update gtest to latest version 1.10.0 (sync)

More info: https://github.com/google/googletest/releases/tag/release-1.10.0

* Adjust cmake variables to be used by Ninja of build byproducts

* Update gtest build recepie according version in root.git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xvallspl @phsft-bot @vgvassilev @lmoneta