Proper check for destruction of global interface object #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
Thanks, Mattias! @phsft-bot build! |
pcanal
reviewed
Apr 3, 2017
|
|
||
| TRInterface::~TRInterface() | ||
| { | ||
| statusEventLoop = kFALSE; |
Member
There was a problem hiding this comment.
Should'nt this also contains
if (gR == this) gR = nullptr;
?
Contributor
|
@phsft-bot build just on slc6/gcc62 |
|
Starting build on |
Member
|
@lmoneta could you rebase instead of merging? |
This was referenced Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"if (gR) { ... }" will not work as a check whether the global interface object is freed. gR - the pointer to the TRInterface object - is assigned by new. Only one instance of this class can be created. There is no explicit delete of this global object, but it is destroyed when the program exits. But this destruction of remaining object when the program ends does not reset the gR pointer to NULL, so using "if (gR) { ... }" as a test to check whether the object is destroyed or not will not work. I think this PR implements the intended behaviour.