Skip to content

Fixes to 10 coverity defect reports #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peremato merged 55 commits into from
Apr 9, 2017
Merged

Fixes to 10 coverity defect reports #480

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
af8c5d5
coverity bugfix 93580: parameters for day montha year were in wrong o…
Feb 28, 2017
89a4a67
coverity 94012: removed redundant unreachable return statement
harveyj1953 Mar 1, 2017
1f8f137
coverity 82573: fixed copy paste error fXaxis to fZaxis
harveyj1953 Mar 1, 2017
baa8987
Coverity 82274: fixed uninitialised class members
harveyj1953 Mar 1, 2017
7b0feb1
coverity 94049: class member not initialised
harveyj1953 Mar 1, 2017
7db5e8c
Coverity 94053: fixed uninitialised class members
harveyj1953 Mar 1, 2017
91ae895
4 coverity bugfixes
harveyj1953 Mar 7, 2017
4929ff4
coverity fixes: 63257, 62811, 62809, 62773, 62332, 62321
harveyj1953 Mar 8, 2017
c34c70d
coverity bugfixes: 62314,61873,61615,61605,61599,61590,61554
harveyj1953 Mar 10, 2017
f67b629
fixed missing initialisation of fModelFunction ptr
harveyj1953 Mar 13, 2017
76e5924
Merge remote-tracking branch 'upstream/master'
harveyj1953 Mar 14, 2017
b02cea7
coverity 68080: 2 uninitialised class members
harveyj1953 Mar 15, 2017
9805120
coverity 68081 and 68084: several uninitialised class members
harveyj1953 Mar 15, 2017
f8e16e0
coverity 68087 and 68086: uninitialised pointers
harveyj1953 Mar 15, 2017
c9e83d5
coverity bug: uninitialised pointer
harveyj1953 Mar 15, 2017
b69fb34
coverity 82584,82583,82582,82581,82580,82579
harveyj1953 Mar 17, 2017
2e9e71e
coverity 82578
harveyj1953 Mar 17, 2017
408d86c
Coverity 68966: truncated return value in mixmax
harveyj1953 Mar 17, 2017
09c2745
coverity 82576,82575
harveyj1953 Mar 17, 2017
6964ee8
coverity 68746,68745
harveyj1953 Mar 17, 2017
d013685
coverity 68958,68853,68852,68849
harveyj1953 Mar 17, 2017
b3ad363
coverity 68860,68857
harveyj1953 Mar 17, 2017
612bef3
coverity 68855
harveyj1953 Mar 17, 2017
d0c3af7
coverity 68962
harveyj1953 Mar 17, 2017
6694183
coverity 68958
harveyj1953 Mar 17, 2017
bb16018
coverity 68731,68730,68729
harveyj1953 Mar 17, 2017
590085e
coverity 68959
harveyj1953 Mar 17, 2017
c41182a
coverity 68856
harveyj1953 Mar 17, 2017
bb0c897
coverity 68080
harveyj1953 Mar 17, 2017
4cdb9db
coverity 68083
harveyj1953 Mar 17, 2017
a28cb14
coverity 68079,68078,68077
harveyj1953 Mar 17, 2017
b479b9d
coverity 68749
harveyj1953 Mar 17, 2017
f9f5674
reverting to original version of llvm code
harveyj1953 Mar 17, 2017
1b85376
coverity 68722: check result of dynamic cast in stressTMVA
harveyj1953 Apr 5, 2017
af624e1
coverity 68720 : check result of dynamic cast in TH1Merger
harveyj1953 Apr 5, 2017
b16d55c
coverity 68719: check result of dynamic cast in TH1Merger
harveyj1953 Apr 5, 2017
cac9d16
coverity 63257: uninitialised scalar field in GSLMultiFitFunctionWrapper
harveyj1953 Apr 5, 2017
6575e9a
coverity 623121 and 62311: uninitialised array elements
harveyj1953 Apr 5, 2017
24e88e0
coverity 62241,42,51,68: fixed 4 memory leaks in testGSLRootFinder
harveyj1953 Apr 5, 2017
4ea4427
Merge branch 'master' into master
peremato Apr 5, 2017
c6d9e58
Update testInterpolation.cxx
peremato Apr 5, 2017
4b5eb01
Update stressTMVA.cxx
peremato Apr 5, 2017
236ac40
Update testInterpolation.cxx
peremato Apr 5, 2017
f6a5aca
Update stressTMVA.cxx
peremato Apr 5, 2017
85d68dd
resolving conflicts with master
harveyj1953 Apr 6, 2017
ff16837
coverity bug fix
harveyj1953 Apr 7, 2017
04fae88
reverting to original file after fix in R__ASSERT
harveyj1953 Apr 7, 2017
ccb3ec6
ignore MacOS specific .DS_Store
harveyj1953 Apr 7, 2017
c0cf732
coverity 94173: memory leak pointer libRIOHandler
harveyj1953 Apr 7, 2017
35a4f25
coverity 61562: memory leak pointer vars
harveyj1953 Apr 7, 2017
c469a01
memory leak variable c
harveyj1953 Apr 7, 2017
b122810
resolving merge conflicts
harveyj1953 Apr 7, 2017
4fcdc32
Revert "coverity 94173: memory leak pointer libRIOHandler"
harveyj1953 Apr 7, 2017
0d10d01
coverity 61577: re-fix of memory link using delete [] c
harveyj1953 Apr 7, 2017
1bfbde8
Update TFormulaTests.cxx
peremato Apr 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into master
  • Loading branch information
@peremato
peremato authored Apr 5, 2017
commit 4ea4427dc894a5b3b9d30b305fd6fbc279c5cba7
1 change: 1 addition & 0 deletions math/mathmore/test/testInterpolation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ void interpolate( const ROOT::Math::Interpolator & itp, bool drawSame = false )
Int_t i = 0;
double xi =0.;
Float_t xcoord[n], ycoord[n];

for ( i = 0; i < 50; ++i) {
Copy link
Member

@vgvassilev vgvassilev Apr 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, was it intentional to increment i twice: once in the loop and once in the loop's body (see last line).

Copy link
Member

@lmoneta lmoneta Apr 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand these changes too. The old code looked perfectly fine to me

xi = 0.2*i;
xcoord[i] = xi;
Expand Down
3 changes: 1 addition & 2 deletions test/stressHistoFit.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,7 @@ void SetParsLimits(vector<ParLimit>& v, TF1* func)
class fitFunctions {
public:
TString name;
double (*func)(double*, double*);
func = nullptr;
double (*func)(double*, double*) = nullptr;
unsigned int npars = 0;
vector<double> origPars;
vector<double> fitPars;
Expand Down
2 changes: 1 addition & 1 deletion test/stressMathMore.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class StatFunction : public ROOT::Math::IParamFunction {
double x1 = -INF,
double x2 = INF ) :
fPdf(&pdf), fCdf(&cdf), fQuant(&quant),
xmin(0.), xmax(0.)
xmin(0.), xmax(0.),
xlow(x1), xup(x2),
fHasLowRange(false), fHasUpRange(false), fStartRoot(0.)
{
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.