Improvements and new interfaces in KahanSum

[xvallspl]

No description provided.

[phsft-bot]

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=ON -Dimt=OFF

[dpiparo]

@xvallspl, @lmoneta : is it really better to have begin and end here? Can't we pass something to iterate on? With range based looping this would not imply any code change in the body of the methods.

[xvallspl]

Hi, Danilo. This was the case in the first of the commits. But it wouldn't work over c arrays, f.e. We decided to remove the other interface for consistency. This way is also closer to std::accumulate.

…

On Thu, Apr 6, 2017, 22:42 Danilo Piparo ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In math/mathcore/inc/Math/Util.h <#485 (comment)>: > } - void Add(const std::vector<T> &elements) + /// Iterate over a datastructure referenced by a pointer and accumulate on the exising result + template <class Iterator> + void Add(const Iterator begin, const Iterator end) @xvallspl <https://github.com/xvallspl>, @lmoneta <https://github.com/lmoneta> : is it really better to have begin and end here? Can't we pass something to iterate on? With range based looping this would not imply any code change in the body of the methods. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#485 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0748psnJDZpWu_rkRmWiQYRdhLEACDks5rtU5LgaJpZM4M1zlr> .

[dpiparo]

@xvallspl : Fine.

[xvallspl]

@phsft-bot build!

[martinmine]

@phsft-bot build!