Skip to content

[TMVA] Fix bug caught by testMinimizationCpu #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Apr 10, 2017
Merged

[TMVA] Fix bug caught by testMinimizationCpu #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[TMVA] Fix bug caught by testMinimizationCpu 
The variable fDropoutProbability in DNN/Layer is being initialized twice
in the constructor, ignoring the value passed in the initialization
list, which causes a bug that breaks TGradientDescent minimizer.
  • Loading branch information
@amadio
amadio committed Apr 10, 2017
commit 03a7eada90756085b86554e3a689bd679cc8f767
2 changes: 0 additions & 2 deletions tmva/tmva/inc/TMVA/DNN/Layer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ TLayer<Architecture_t>::TLayer(const TLayer &layer)
{
Architecture_t::Copy(fWeights, layer.GetWeights());
Architecture_t::Copy(fBiases, layer.GetBiases());
fDropoutProbability = 0.;
}

//______________________________________________________________________________
Expand Down Expand Up @@ -336,7 +335,6 @@ TSharedLayer<Architecture_t>::TSharedLayer(const TSharedLayer &layer)
fBiasGradients(fWidth, 1), fActivationGradients(layer.fBatchSize, fWidth),
fF(layer.fF)
{
fDropoutProbability = 0.;
}

//______________________________________________________________________________
Expand Down