Skip to content

Use tolerance to compare floating point numbers in testGenVector.cxx #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Apr 12, 2017
Merged

Use tolerance to compare floating point numbers in testGenVector.cxx #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use tolerance to compare floating point numbers 
The exact comparison fails in some architectures where rounding
may occur.
  • Loading branch information
@amadio
amadio committed Apr 11, 2017
commit c06d53c6c0fe261fcf227d96ff73361818c2d2ec
4 changes: 3 additions & 1 deletion math/genvector/test/testGenVector.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,9 @@ int testTransform3D() {
Transform3D tr(EulerAngles(10, -10, 10), XYZVector(10, -10, 0));
auto r1 = tr.ApplyInverse(vector);
auto r2 = tr.Inverse()(vector);
iret |= compare((r1 == r2), true, "ApplyInverse/Vector");
iret |= compare(r1.X(), r2.X(), "ApplyInverse/Vector", 10);
iret |= compare(r1.Y(), r2.Y(), "ApplyInverse/Vector", 10);
iret |= compare(r1.Z(), r2.Z(), "ApplyInverse/Vector", 10);
}

if (iret == 0) std::cout << "OK\n";
Expand Down